-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid useless fomantic rebuilds #9999
Conversation
the `fomantic` target for some reason does sometimes not update the timestamp on the directory, leading to useless rebuild. Manually update the timestamp at the end of the build to avoid this and also added the same to js/css targets.
Codecov Report
@@ Coverage Diff @@
## master #9999 +/- ##
==========================================
- Coverage 42.26% 42.26% -0.01%
==========================================
Files 610 610
Lines 80372 80372
==========================================
- Hits 33973 33967 -6
- Misses 42220 42228 +8
+ Partials 4179 4177 -2
Continue to review full report at Codecov.
|
Yup seems to fix it. BTW the advice github gives for testing PRs is kinda wrong - if you just wanna test the branch as it stands without merging into master:
|
Thanks @silverwind this will save so much time - (and my fans coming on so much!) |
Directory timestamps are not modified if no files are added/removed from them. So, your modification makes sense in case the step ran successfully over previously existing files. However, regardless of this change, I'd like to point out that rule checking against directories is not a recommended practice:
If the Makefile step fails mid-way ( Let me give you an example:
Let The problem comes if either An example of this situation is when you manually interrupt the build ( This will not affect our CI process, because CI steps either run or not, but are never interrupted and restarted. But we should be aware that the contents of |
Adding to the problem above, we need to keep in mind that |
Ah, I didn't know that, thanks. I think the manual
I'd expect users to run |
Yes,
Because we're having different versions of
I've found this problem in the past (I just clean manually). |
the
fomantic
target for some reason does sometimes not update the timestamp on the destination directory, leading to useless rebuild.Manually update the timestamp at the end of the build to avoid this and also added the same to js/css targets.
@zeripath see if that helps.