Use a file as make evidence for fomantic instead of a directory

[guillep2k]

This PR follows #9999 (comment) by using a file as fomantic build evidence instead of the fomantic directory.

I've also added web_src/fomantic_site_globals/* as dependencies, because they're input files as well.

[codecov-io]

Codecov Report

Merging #10032 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10032      +/-   ##
==========================================
+ Coverage   43.44%   43.45%   +0.01%     
==========================================
  Files         566      566              
  Lines       78987    78987              
==========================================
+ Hits        34317    34327      +10     
+ Misses      40430    40423       -7     
+ Partials     4240     4237       -3

Impacted Files	Coverage Δ
services/pull/pull.go	33.93% <0%> (ø)	⬆️
modules/queue/manager.go	60.51% <0%> (-1.54%)	⬇️
models/repo.go	51.46% <0%> (+0.13%)	⬆️
services/pull/check.go	56.64% <0%> (+1.39%)	⬆️
modules/process/manager.go	78.31% <0%> (+3.61%)	⬆️
services/pull/patch.go	69.81% <0%> (+3.77%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884519c...8d78c5c. Read the comment docs.

[zeripath]

Hmm... I went for hashes in the bindata because the timestamps of the directories etc may not increase when you git checkout branch. I don't know enough about make's dependency process - does it cope with that?

[silverwind]

does it cope with that?

I don't think make can do anything else but timestamp checks. Thought I guess something with content hashes could be hacked together, like https://medium.com/@mtiller/using-git-hashes-in-makefile-rules-387a099b9cb.

[guillep2k]

Hmm... I went for hashes in the bindata because the timestamps of the directories etc may not increase when you git checkout branch. I don't know enough about make's dependency process - does it cope with that?

@zeripath Make could trigger any process you want and make a dependency out of it, as long as there's a file timestamp involved. For example:

GOFILES := $(shell find . -name "*.go" -type f ! -path "./vendor/*" ! -path "*/bindata.go")

generates a list of go files we use as dependencies; any of them change, make knows that the dependent rules need to be run.

The reason I didn't suggest you this path is because generate is used for more than creating bindata.go. If you'd like to use make timestamping for that (and you could) you'd need to take the bindata.go process out of generate and run it from outside. It's doable, but not much different from what you did.

The weak point of make is when you remove a file that was a dependency: make won't know about that. It's simply something that it's not in the list of dependencies anymore, so it won't trigger the corresponding rules (e.g. should we remove some .go file, make will not know that it needs to rebuild unless other .go files are modified).

Make is all about: "Is any of these files newer than the target? Run the recipe!"

[silverwind]

Maybe just add a FOMANTIC_SOURCES ?= $(shell find web_src/fomantic -type f) and add that to prereqs? I think that might be cleaner.

[guillep2k]

Maybe just add a FOMANTIC_SOURCES ?= $(shell find web_src/fomantic -type f) and add that to prereqs? I think that might be cleaner.

Cleaner indeed. Done.

[zeripath]

make lg-tm work