Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] add endpoint to check notifications [Extend #9488] #9595

Merged
merged 6 commits into from
Jan 14, 2020
Merged

[API] add endpoint to check notifications [Extend #9488] #9595

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
db2dca8
introduce GET /notifications/new
6543 Jan 3, 2020
0f2b571
add TEST
6543 Jan 3, 2020
98bb9e2
use Sprintf instead of path.Join
6543 Jan 12, 2020
049d907
Error more verbose
6543 Jan 12, 2020
42ef28e
return number of notifications if unreaded exist
6543 Jan 12, 2020
c5cb836
200 http status for available notifications
6543 Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Error more verbose
  • Loading branch information
@6543
6543 committed Jan 14, 2020
commit 049d90787cfcbb83610a69ab0d7e5a9f6d650b45
2 changes: 1 addition & 1 deletion models/notification.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ func (n *Notification) loadComment(e Engine) (err error) {
if n.Comment == nil && n.CommentID > 0 {
n.Comment, err = GetCommentByID(n.CommentID)
if err != nil {
return fmt.Errorf("GetCommentByID [%d]: %v", n.CommentID, err)
return fmt.Errorf("GetCommentByID [%d] for issue ID [%d]: %v", n.CommentID, n.IssueID, err)
}
}
return nil
Expand Down