[API] add endpoint to check notifications [Extend #9488]

[6543]

extend #9488

an endpoint wich e.g. mobile clients can use to check if news are available (use less bandwith than any other notification endpoint ...)

-> GET /notifications/new

• status 200 (OK) -> Notifications Available
• status 204 (No Content) -> News Notifications

[codecov-io]

Codecov Report

Merging #9595 into master will increase coverage by 0.03%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #9595      +/-   ##
==========================================
+ Coverage    42.3%   42.33%   +0.03%     
==========================================
  Files         599      600       +1     
  Lines       78330    78357      +27     
==========================================
+ Hits        33135    33170      +35     
+ Misses      41140    41129      -11     
- Partials     4055     4058       +3

Impacted Files	Coverage Δ
models/issue_comment.go	46.4% <0%> (ø)	⬆️
routers/api/v1/notify/notifications.go	100% <100%> (ø)
routers/api/v1/api.go	74.45% <100%> (+0.03%)	⬆️
models/issue.go	55.42% <100%> (ø)	⬆️
models/notification.go	64.13% <50%> (-0.17%)	⬇️
services/pull/temp_repo.go	31.62% <0%> (-2.57%)	⬇️
models/webhook.go	70.46% <0%> (+1.06%)	⬆️
modules/queue/workerpool.go	41.2% <0%> (+1.28%)	⬆️
services/pull/check.go	53.37% <0%> (+4.72%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce274d6...c5cb836. Read the comment docs.

[zeripath]

Would it be possible to make it return the number of unread notifications or do you think that would be slower?

[6543]

Would it be possible to make it return the number of unread notifications or do you think that would be slower?

since github doesnt have souch an endpoint it's gitea-definde :)

@zeripath: I can send a simple json struct new: 2 or so ?

[zeripath]

That would do - my reasoning is that this might be a useful thing for us to query instead of rendering the number of notifications directly on the server.

[6543]

@zeripath added/changed

[sapk]

I will not block but I feel that 302 found (even more with json content) is not the best response code compared to what is defined in the RFC. I will try to have a look later if merged.

6.4.3.  302 Found

   The 302 (Found) status code indicates that the target resource
   resides temporarily under a different URI.  Since the redirection
   might be altered on occasion, the client ought to continue to use the
   effective request URI for future requests.
   The server SHOULD generate a Location header field in the response
   containing a URI reference for the different URI.  The user agent MAY
   use the Location field value for automatic redirection.  The server's
   response payload usually contains a short hypertext note with a
   hyperlink to the different URI(s).

      Note: For historical reasons, a user agent MAY change the request
      method from POST to GET for the subsequent request.  If this
      behavior is undesired, the 307 (Temporary Redirect) status code
      can be used instead.

[6543]

@sapk 302s Name was to good to be true for my intention ... the meaning was different :/ ...

so 200 and 204 are totaly ok 👍

[sapk]

CI failed because swagger order the http response and now 200 is on top of 204.

[6543]

I'm now on my PC I'll patch this localy ...

[6543]

@sapk done

[6543]

ready to merge 🚀

[sapk]

Just to make all checks green