Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue search support elasticsearch #9428

Merged
merged 6 commits into from
Feb 13, 2020
Merged

Issue search support elasticsearch #9428

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77707c2
Issue search support elasticsearch
lunny Dec 19, 2019
d911c85
Fix lint
lunny Dec 19, 2019
360c47c
Add indexer name on app.ini
lunny Dec 19, 2019
a4b8ab7
add a warnning on SearchIssuesByKeyword
lunny Dec 20, 2019
e41403b
improve code
lunny Dec 20, 2019
0aff658
Merge branch 'master' into lunny/issue_indexer_es2
lunny Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a warnning on SearchIssuesByKeyword
  • Loading branch information
@lunny
lunny committed Feb 12, 2020
commit a4b8ab7a8fed5ba9c98a422e6c301caa8da33774
1 change: 1 addition & 0 deletions modules/indexer/issues/indexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ func DeleteRepoIssueIndexer(repo *models.Repository) {
}

// SearchIssuesByKeyword search issue ids by keywords and repo id
// WARNNING: You have to ensure user have permission to visit repoIDs' issues
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This messes up with our paging, but I don't see much way around it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I left it for future PR.

func SearchIssuesByKeyword(repoIDs []int64, keyword string) ([]int64, error) {
var issueIDs []int64
indexer := holder.get()
Expand Down