Issue search support elasticsearch #9428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/feature
Codecov Report
@@ Coverage Diff @@
## master #9428 +/- ##
==========================================
+ Coverage 42.36% 43.67% +1.31%
==========================================
Files 619 577 -42
Lines 81003 79869 -1134
==========================================
+ Hits 34313 34885 +572
+ Misses 42482 40676 -1806
- Partials 4208 4308 +100
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
reviewed
Dec 19, 2019
lafriks
reviewed
Dec 19, 2019
lafriks
reviewed
Dec 19, 2019
lunny
force-pushed
the
lunny/issue_indexer_es2
branch
from
09b7458
to
c23ffc6
Compare
guillep2k
reviewed
Dec 20, 2019
lunny
force-pushed
the
lunny/issue_indexer_es2
branch
from
c23ffc6
to
580e2cb
Compare
|
Partilly fix #6648 |
6543
reviewed
Dec 25, 2019
GiteaBot
added
lgtm/need 1
|
I think your rebase broke something ... |
lunny
force-pushed
the
lunny/issue_indexer_es2
branch
from
565f0ea
to
d31ba64
Compare
|
@6543 fixed. :) |
lunny
force-pushed
the
lunny/issue_indexer_es2
branch
from
d31ba64
to
51a65a2
Compare
guillep2k
reviewed
Feb 11, 2020
| "mappings": { | ||
| "properties": { | ||
| "id": { | ||
| "type": "integer", |
There was a problem hiding this comment.
Is this compatible with int64?
| if len(repoIDs) > 0 { | ||
| var repoStrs = make([]interface{}, 0, len(repoIDs)) | ||
| for _, repoID := range repoIDs { | ||
| repoStrs = append(repoStrs, repoID) |
There was a problem hiding this comment.
Is this intended to be a string, or just []interface{}?
There was a problem hiding this comment.
Because NewTermsQuery needs a slice of interface as parameters.
| @@ -310,6 +323,7 @@ func DeleteRepoIssueIndexer(repo *models.Repository) { | |||
| } | |||
|
|
|||
| // SearchIssuesByKeyword search issue ids by keywords and repo id | |||
| // WARNNING: You have to ensure user have permission to visit repoIDs' issues | |||
There was a problem hiding this comment.
This messes up with our paging, but I don't see much way around it.
There was a problem hiding this comment.
Yes. I left it for future PR.
guillep2k
approved these changes
Feb 11, 2020
GiteaBot
added
lgtm/done
6543
approved these changes
Feb 11, 2020
lunny
force-pushed
the
lunny/issue_indexer_es2
branch
from
d965f11
to
e41403b
Compare
|
make L-G-T-M work. |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #6150
This PR introduce a new issue indexer type - elasticsearch.
It will connect to an elasticsearch server or cluster to store issue indexer and search by keyword.
This will have better performance than
dborbleveon a bigger gitea instance.Especially there are serval gitea instances to share indexer.
This PR also added a test for elastic search issue indexer.