Fix wrong text getting saved on editing second comment on an issue. #5608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug that was causing text from previously edited comment to get saved when two comments were edited one after other. Text area with id of `#content` isn't unique on the page but it was being treated as unique by the event handling code. Fixes: go-gitea#5581.
An element is assigned an `id` only if it is unique for the whole page but in this case there can be multiple textarea so it should have one.
Codecov Report
@@ Coverage Diff @@
## master #5608 +/- ##
=========================================
- Coverage 37.51% 37.5% -0.01%
=========================================
Files 322 322
Lines 47458 47458
=========================================
- Hits 17804 17801 -3
- Misses 27097 27099 +2
- Partials 2557 2558 +1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lafriks
approved these changes
Dec 30, 2018
bkcsoft
added
lgtm/need 1
jonasfranz
approved these changes
Dec 31, 2018
bkcsoft
added
lgtm/done
|
@HarshitOnGitHub please send back port to release/v1.6 |
HarshitOnGitHub
added a commit
to HarshitOnGitHub/gitea
that referenced
this pull request
Dec 31, 2018
…o-gitea#5608) * comments: Fix an incorrent DOM element selection. This commit fixes a bug that was causing text from previously edited comment to get saved when two comments were edited one after other. Text area with id of `#content` isn't unique on the page but it was being treated as unique by the event handling code. Fixes: go-gitea#5581. * templates: Remove `id` from textarea in commit edit form. An element is assigned an `id` only if it is unique for the whole page but in this case there can be multiple textarea so it should have one.
techknowlogick
pushed a commit
that referenced
this pull request
Dec 31, 2018
…5608) (#5615) * comments: Fix an incorrent DOM element selection. This commit fixes a bug that was causing text from previously edited comment to get saved when two comments were edited one after other. Text area with id of `#content` isn't unique on the page but it was being treated as unique by the event handling code. Fixes: #5581. * templates: Remove `id` from textarea in commit edit form. An element is assigned an `id` only if it is unique for the whole page but in this case there can be multiple textarea so it should have one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5581.