Wrong text after editing second comment on an issue #5581
Comments
HarshitOnGitHub
added a commit
to HarshitOnGitHub/gitea
that referenced
this issue
Dec 29, 2018
This commit fixes a bug that was causing text from previously edited comment to get saved when two comments were edited one after other. Text area with id of `#content` isn't unique on the page but it was being treated as unique by the event handling code. Fixes: go-gitea#5581.
jonasfranz
pushed a commit
that referenced
this issue
Dec 31, 2018
…5608) * comments: Fix an incorrent DOM element selection. This commit fixes a bug that was causing text from previously edited comment to get saved when two comments were edited one after other. Text area with id of `#content` isn't unique on the page but it was being treated as unique by the event handling code. Fixes: #5581. * templates: Remove `id` from textarea in commit edit form. An element is assigned an `id` only if it is unique for the whole page but in this case there can be multiple textarea so it should have one.
HarshitOnGitHub
added a commit
to HarshitOnGitHub/gitea
that referenced
this issue
Dec 31, 2018
…o-gitea#5608) * comments: Fix an incorrent DOM element selection. This commit fixes a bug that was causing text from previously edited comment to get saved when two comments were edited one after other. Text area with id of `#content` isn't unique on the page but it was being treated as unique by the event handling code. Fixes: go-gitea#5581. * templates: Remove `id` from textarea in commit edit form. An element is assigned an `id` only if it is unique for the whole page but in this case there can be multiple textarea so it should have one.
techknowlogick
pushed a commit
that referenced
this issue
Dec 31, 2018
…5608) (#5615) * comments: Fix an incorrent DOM element selection. This commit fixes a bug that was causing text from previously edited comment to get saved when two comments were edited one after other. Text area with id of `#content` isn't unique on the page but it was being treated as unique by the event handling code. Fixes: #5581. * templates: Remove `id` from textarea in commit edit form. An element is assigned an `id` only if it is unique for the whole page but in this case there can be multiple textarea so it should have one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
[x]):Description
Steps to reproduce
Expected behaviour
The text from the second comment gets editable and the correct text gets shown after saving the comment
Current behaviour
The text from the first comment gets pulled and no matter what you type, the text from the first comment gets saved instead of the current text
Screenshots
The text was updated successfully, but these errors were encountered: