Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

word-break the WebHook url to prevent a ui-break #5432

Merged
merged 4 commits into from
Nov 30, 2018
Merged

word-break the WebHook url to prevent a ui-break #5432

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23cc5c2
word-break the WebHook url to prevent a ui-break
r-52 Nov 30, 2018
00bea14
Merge branch 'master' into r-wrap-the-url-in-webhooks
lafriks Nov 30, 2018
93346b6
Merge branch 'master' into r-wrap-the-url-in-webhooks
lunny Nov 30, 2018
6659077
Merge branch 'master' into r-wrap-the-url-in-webhooks
techknowlogick Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
word-break the WebHook url to prevent a ui-break 
right now, the url is displayed with an anchor tag with no classes. If
the url is really really long, the url will break out of the containing
div and (depending on the url length) the browser shows the horizontal
scrollbar.
This pr makes use of the already existing css class `dont-break-out`
which gives all the anchor the necessary properties to prevent the
break.
Another solution could be to introduce some classes like
`text text-break-word`, but that would duplicate the `dont-break-out`
class just for text elements that use the `text` class.

fixes: #5416
Signed-off-by: Roman <[email protected]>
  • Loading branch information
@r-52
r-52 committed Nov 30, 2018
commit 23cc5c2d2c68ef121ac5aa21b1b5af7ac9f6462e
2 changes: 1 addition & 1 deletion templates/repo/settings/webhook/list.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
{{else}}
<span class="text grey"><i class="octicon octicon-primitive-dot"></i></span>
{{end}}
<a href="{{$.BaseLink}}/settings/hooks/{{.ID}}">{{.URL}}</a>
<a class="dont-break-out" href="{{$.BaseLink}}/settings/hooks/{{.ID}}">{{.URL}}</a>
<div class="ui right">
<span class="text blue"><a href="{{$.BaseLink}}/settings/hooks/{{.ID}}"><i class="fa fa-pencil"></i></a></span>
<span class="text red"><a class="delete-button" data-url="{{$.Link}}/delete" data-id="{{.ID}}"><i class="fa fa-times"></i></a></span>
Expand Down