Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

word-break the WebHook url to prevent a ui-break #5432

Merged
merged 4 commits into from
Nov 30, 2018
Merged

word-break the WebHook url to prevent a ui-break #5432

merged 4 commits into from
Nov 30, 2018

Commits on Nov 30, 2018

  1. word-break the WebHook url to prevent a ui-break 

    right now, the url is displayed with an anchor tag with no classes. If
the url is really really long, the url will break out of the containing
div and (depending on the url length) the browser shows the horizontal
scrollbar.
This pr makes use of the already existing css class `dont-break-out`
which gives all the anchor the necessary properties to prevent the
break.
Another solution could be to introduce some classes like
`text text-break-word`, but that would duplicate the `dont-break-out`
class just for text elements that use the `text` class.

fixes: go-gitea#5416
Signed-off-by: Roman <[email protected]>
    @r-52
    r-52 committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    23cc5c2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into r-wrap-the-url-in-webhooks

    @lafriks
    lafriks committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    00bea14 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into r-wrap-the-url-in-webhooks

    @lunny
    lunny committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    93346b6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into r-wrap-the-url-in-webhooks

    @techknowlogick
    techknowlogick committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    6659077 View commit details
    Browse the repository at this point in the history