Removing Labels via EditPullRequest API #5348
Conversation
…PI to remove all labels Signed-off-by: Lucien Kerl <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5348 +/- ##
=======================================
Coverage 37.56% 37.56%
=======================================
Files 317 317
Lines 46821 46821
=======================================
Hits 17590 17590
Misses 26732 26732
Partials 2499 2499
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
routers/api/v1/repo/pull.go
Outdated
| @@ -405,7 +405,7 @@ func EditPullRequest(ctx *context.APIContext, form api.EditPullRequestOption) { | |||
| } | |||
| } | |||
|
|
|||
| if ctx.Repo.IsWriter() && (form.Labels != nil && len(form.Labels) > 0) { | |||
| if ctx.Repo.IsWriter() && form.Labels != nil { | |||
There was a problem hiding this comment.
Will this remove all labels not provided in the request?
Example: I have 5 labels.
- Request: Add label 1,4,2
- Request: Add label 3
Would this then have 1,2,3,4 or only 3?
There was a problem hiding this comment.
Yes, this will remove all labels not provided in the request.
This would only have the label3 then.
Otherwise you would not be able to delete labels.
|
As adding labels by API was just merged and this is change is recent functionality I'm not adding breaking label for this |
bkcsoft
added
lgtm/need 1
|
Tests will be better. |
bkcsoft
added
lgtm/done
|
@lucienkerl file conflicted. |
routers/api/v1/repo/pull.go
Outdated
| @@ -405,7 +405,8 @@ func EditPullRequest(ctx *context.APIContext, form api.EditPullRequestOption) { | |||
| } | |||
| } | |||
|
|
|||
| if ctx.Repo.CanWrite(models.UnitTypePullRequests) && (form.Labels != nil && len(form.Labels) > 0) { | |||
| if ctx.Repo.CanWrite(models.UnitTypePullRequests) && form.Labels != nil { | |||
|
|
|||
Because of a comment at the PR #5347 I recognized that it is currently not possible to remove labels.
This PR adds the ability to provide an empty labels array to remove all labels from a PR.