Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Labels via EditPullRequest API #5347

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Conversation

lucienkerl
Copy link
Contributor

According to the documentation it is possible to set labels at pull requests via API. However this wasn't implemented. The PR extends the API to be able to set labels.

@codecov-io
Copy link

Codecov Report

Merging #5347 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5347      +/-   ##
==========================================
- Coverage   37.37%   37.36%   -0.02%     
==========================================
  Files         312      312              
  Lines       46399    46409      +10     
==========================================
- Hits        17341    17339       -2     
- Misses      26574    26586      +12     
  Partials     2484     2484
Impacted Files Coverage Δ
routers/api/v1/repo/pull.go 17.28% <0%> (-0.32%) ⬇️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7278372...e6ef3b0. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 16, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 16, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2018
@jonasfranz jonasfranz merged commit 89eea64 into go-gitea:master Nov 16, 2018
@lafriks lafriks added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Nov 16, 2018
@lafriks lafriks added this to the 1.7.0 milestone Nov 16, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants