Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility heatmap with mysql 8 #5232

Merged
merged 1 commit into from
Oct 31, 2018
Merged

fix compatibility heatmap with mysql 8 #5232

merged 1 commit into from
Oct 31, 2018

Conversation

gaydin
Copy link

@gaydin gaydin commented Oct 31, 2018

Updated SQL query for compatibility with the latest version of mysql.

Resolves: #5220

@codecov-io
Copy link

Codecov Report

Merging #5232 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5232      +/-   ##
==========================================
+ Coverage   37.47%   37.48%   +0.01%     
==========================================
  Files         310      310              
  Lines       45923    45923              
==========================================
+ Hits        17210    17215       +5     
+ Misses      26238    26234       -4     
+ Partials     2475     2474       -1
Impacted Files Coverage Δ
models/user_heatmap.go 80% <100%> (ø) ⬆️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7edb930...67e5d70. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 31, 2018
@lunny lunny added the type/bug label Oct 31, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 31, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 31, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 31, 2018
@techknowlogick techknowlogick merged commit 794049e into go-gitea:master Oct 31, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard heatmap always loading on mysql 8
7 participants