Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard heatmap always loading on mysql 8 #5220

Closed
2 of 7 tasks
gaydin opened this issue Oct 29, 2018 · 3 comments · Fixed by #5232
Closed
2 of 7 tasks

Dashboard heatmap always loading on mysql 8 #5220

gaydin opened this issue Oct 29, 2018 · 3 comments · Fixed by #5232
Labels
Milestone

Comments

@gaydin
Copy link

gaydin commented Oct 29, 2018

  • Gitea version (or commit ref): d4e6278
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

https://gist.github.com/gaydin/ee00f012fbefe913daa53a98c0c55f1c

Description

Maybe need changed
https://github.com/go-gitea/gitea/blob/master/models/user_heatmap.go#L26
UNIX_TIMESTAMP(DATE_FORMAT(FROM_UNIXTIME(created_unix), '%Y%m%d'))
to
UNIX_TIMESTAMP(DATE(FROM_UNIXTIME(created_unix)))

@lafriks lafriks modified the milestones: 1.6.1, 1.7.0 Oct 30, 2018
@kolaente
Copy link
Member

Does this also fail in mysql 5/ mariadb 10?

@gaydin
Copy link
Author

gaydin commented Oct 31, 2018

I tested on MySQL 5.6.37 - work fine.
Trouble with mysql 8.0.13 only.
After changing DATE_FORMAT to DATE works fine on MySQL 5.6 and 8

@sapk
Copy link
Member

sapk commented Oct 31, 2018

@gaydin do you know how to make a PR ?
If not maybe we could add a label good first issue to attract new contributor ?

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants