Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update x/net lib #5169

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Update x/net lib #5169

merged 3 commits into from
Oct 26, 2018

Conversation

sapk
Copy link
Member

@sapk sapk commented Oct 24, 2018

Changelog: golang/net@f249948...master

Related: #4817

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 24, 2018
@codecov-io
Copy link

codecov-io commented Oct 24, 2018 •
edited
Loading

Codecov Report

Merging #5169 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5169      +/-   ##
==========================================
- Coverage   37.52%   37.49%   -0.04%     
==========================================
  Files         309      309              
  Lines       45791    45791              
==========================================
- Hits        17185    17169      -16     
- Misses      26143    26159      +16     
  Partials     2463     2463
Impacted Files Coverage Δ
modules/indexer/repo.go 64.28% <0%> (-5.56%) ⬇️
models/repo_indexer.go 50.84% <0%> (-2.97%) ⬇️
models/repo_list.go 62.2% <0%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f887085...f868c76. Read the comment docs.

@sapk
Copy link
Member Author

sapk commented Oct 24, 2018

Note for an other PR: bleve and goth (PR in progress) could be updated to remove the x/net/context vendor since it is a standard package from Go1.7.

techknowlogick
techknowlogick approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably should wait for #5167 before this PR gets merged.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 25, 2018
@sapk sapk mentioned this pull request Oct 26, 2018
Merged
@lafriks lafriks added this to the 1.7.0 milestone Oct 26, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 26, 2018
@techknowlogick techknowlogick merged commit 2af57c7 into go-gitea:master Oct 26, 2018
@sapk sapk deleted the update-net branch October 27, 2018 11:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sapk @codecov-io @techknowlogick @lafriks @bkcsoft @lunny