Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #5146 #5167

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Revert #5146 #5167

merged 1 commit into from
Oct 25, 2018

Conversation

sapk
Copy link
Member

@sapk sapk commented Oct 24, 2018

Revert #5146 to keep a check of lowest supported configuration.

@codecov-io
Copy link

Codecov Report

Merging #5167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5167   +/-   ##
=======================================
  Coverage   37.49%   37.49%           
=======================================
  Files         309      309           
  Lines       45786    45786           
=======================================
  Hits        17166    17166           
  Misses      26158    26158           
  Partials     2462     2462

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd5fb8...0d42356. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 24, 2018
@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Oct 24, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 24, 2018
@lunny
Copy link
Member

lunny commented Oct 25, 2018

for Gitea v1.7 maybe we should change the lowest go version from go1.9 to go1.11 for using go modules?

@techknowlogick
Copy link
Member

@lunny per https://blog.gitea.io/2018/08/gitea-1.5.0-is-released/ our lowest is already 1.9

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2018
@lunny lunny merged commit c258ae8 into go-gitea:master Oct 25, 2018
@sapk sapk deleted the revert-5146 branch October 25, 2018 09:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants