Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated Go toolchain version for .drone.yml #5146

Merged
merged 2 commits into from
Oct 23, 2018

Conversation

typeless
Copy link
Contributor

Other CI pipelines already use Go1.11. So, we update this one too.

@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #5146 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5146      +/-   ##
==========================================
- Coverage   37.48%   37.47%   -0.01%     
==========================================
  Files         309      309              
  Lines       45782    45782              
==========================================
- Hits        17162    17158       -4     
- Misses      26159    26160       +1     
- Partials     2461     2464       +3
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_indexer.go 50.84% <0%> (-1.28%) ⬇️
models/repo_list.go 63.37% <0%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c49cf...546bc28. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 23, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 23, 2018
@techknowlogick techknowlogick merged commit 159c2ff into go-gitea:master Oct 23, 2018
@lafriks
Copy link
Member

lafriks commented Oct 24, 2018

Nooooo.... Please send PR to change it back as it was intentionally left this way to test if gitea builds with lowest supported golang toolchain version

sapk added a commit to sapk-fork/gitea that referenced this pull request Oct 24, 2018
@sapk sapk mentioned this pull request Oct 24, 2018
@lunny
Copy link
Member

lunny commented Oct 25, 2018

@lafriks for Gitea v1.7 maybe we should change the lowest go version from go1.9 to go1.11 for using go modules?

@lafriks
Copy link
Member

lafriks commented Oct 25, 2018

@lunny probably but this change should come also with that migration to go modules and updated docs

@lunny
Copy link
Member

lunny commented Oct 25, 2018

OK

lunny pushed a commit that referenced this pull request Oct 25, 2018
@typeless typeless deleted the update-go-for-ci branch April 3, 2019 05:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants