update function naming and use strings#ToLower

modules/auth/user_form.go

@@ -87,11 +87,11 @@ func (f *RegisterForm) Validate(ctx *macaron.Context, errs binding.Errors) bindi
  return validate(errs, ctx.Data, f, ctx.Locale)
 }
 
-// IsEmaildomainwhitelisted validates that the email address
+// IsEmailDomainWhitelisted validates that the email address
 // provided by the user matches what has been configured .
 // If the domain whitelist from the config is empty, it marks the
 // email as whitelisted
-func (f RegisterForm) IsEmaildomainwhitelisted() bool {
+func (f RegisterForm) IsEmailDomainWhitelisted() bool {
  if len(setting.Service.EmailDomainWhitelist) == 0 {
  return true
  }
@@ -101,10 +101,10 @@ func (f RegisterForm) IsEmaildomainwhitelisted() bool {
  return false
  }
 
- domain := f.Email[n+1:]
+ domain := strings.ToLower(f.Email[n+1:])
 
  for _, v := range setting.Service.EmailDomainWhitelist {
- if v == domain {
+ if strings.ToLower(v) == domain {
  return true
  }
  }

modules/auth/user_form_test.go

@@ -19,7 +19,7 @@ func TestRegisterForm_IsDomainWhiteList_Empty(t *testing.T) {
 
  form := RegisterForm{}
 
- assert.True(t, form.IsEmaildomainwhitelisted())
+ assert.True(t, form.IsEmailDomainWhitelisted())
 }
 
 func TestRegisterForm_IsDomainWhiteList_InvalidEmail(t *testing.T) {
@@ -37,7 +37,7 @@ func TestRegisterForm_IsDomainWhiteList_InvalidEmail(t *testing.T) {
  for _, v := range tt {
  form := RegisterForm{Email: v.email}
 
- assert.False(t, form.IsEmaildomainwhitelisted())
+ assert.False(t, form.IsEmailDomainWhitelisted())
  }
 }
 
@@ -51,13 +51,14 @@ func TestRegisterForm_IsDomainWhiteList_ValidEmail(t *testing.T) {
  valid bool
  }{
  {"[email protected]", true},
+ {"[email protected]", true},
  {"hdudhdd", false},
  {"[email protected]", false},
  }
 
  for _, v := range tt {
  form := RegisterForm{Email: v.email}
 
- assert.Equal(t, v.valid, form.IsEmaildomainwhitelisted())
+ assert.Equal(t, v.valid, form.IsEmailDomainWhitelisted())
  }
 }

routers/user/auth.go

@@ -948,7 +948,7 @@ func SignUpPost(ctx *context.Context, cpt *captcha.Captcha, form auth.RegisterFo
  }
  }
 
- if !form.IsEmaildomainwhitelisted() {
+ if !form.IsEmailDomainWhitelisted() {
  ctx.RenderWithErr(ctx.Tr("auth.email_domain_blacklisted"), tplSignUp, &form)
  return
  }