Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block registration based on email domain #5157

Merged
merged 11 commits into from
Nov 15, 2018
Merged

Block registration based on email domain #5157

merged 11 commits into from
Nov 15, 2018

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Oct 23, 2018

Fixes #4305

@adelowo adelowo force-pushed the limit_registration_to_email_domain branch from f654896 to e672015 Compare October 23, 2018 23:26
@adelowo
Copy link
Member Author

adelowo commented Oct 24, 2018

Can a maintainer restart the build ? ... It seems to cancel after timing out

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 24, 2018
@appleboy
Copy link
Member

@adelowo restart the PR build.

@lunny lunny added the type/enhancement An improvement of existing functionality label Oct 24, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 24, 2018
@codecov-io
Copy link

codecov-io commented Oct 24, 2018 •
edited

Codecov Report

Merging #5157 into master will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5157      +/-   ##
==========================================
- Coverage   37.37%   37.36%   -0.01%     
==========================================
  Files         312      312              
  Lines       46379    46399      +20     
==========================================
+ Hits        17332    17338       +6     
- Misses      26567    26576       +9     
- Partials     2480     2485       +5
Impacted Files Coverage Δ
routers/user/auth.go 13.28% <0%> (-0.06%) ⬇️
modules/auth/user_form.go 51.11% <100%> (+24.44%) ⬆️
modules/setting/setting.go 48.12% <100%> (+0.06%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_indexer.go 44.49% <0%> (-3.82%) ⬇️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1f1f9...2f35804. Read the comment docs.

lafriks
lafriks requested changes Oct 25, 2018
View reviewed changes
modules/auth/user_form.go Show resolved Hide resolved
custom/conf/app.ini.sample Show resolved Hide resolved
@adelowo adelowo force-pushed the limit_registration_to_email_domain branch from 0fdf05e to 4fdd1ae Compare October 25, 2018 13:05
lafriks
lafriks requested changes Nov 2, 2018
View reviewed changes
modules/auth/user_form.go Outdated Show resolved Hide resolved
modules/auth/user_form.go Outdated Show resolved Hide resolved
modules/auth/user_form.go Outdated Show resolved Hide resolved
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 3, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 15, 2018
@techknowlogick techknowlogick merged commit b97af15 into go-gitea:master Nov 15, 2018
@adelowo adelowo deleted the limit_registration_to_email_domain branch November 15, 2018 01:01
@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label Nov 15, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Block registration based on email domain
8 participants
@adelowo @appleboy @codecov-io @techknowlogick @lafriks @lunny @bkcsoft @delvh