Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the retry limit to 20 times and the interval to 200ms #5134

Merged
merged 1 commit into from
Oct 21, 2018

Conversation

typeless
Copy link
Contributor

@typeless typeless commented Oct 21, 2018

The original settings have less tolerance and would fail in some environments.

Fixes the test failure in #5133

The original settings has less tolerance and would fail on some
environments.
@codecov-io
Copy link

Codecov Report

Merging #5134 into master will decrease coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5134      +/-   ##
==========================================
- Coverage   37.44%   37.44%   -0.01%     
==========================================
  Files         308      308              
  Lines       45711    45715       +4     
==========================================
  Hits        17116    17116              
- Misses      26136    26139       +3     
- Partials     2459     2460       +1
Impacted Files Coverage Δ
models/test_fixtures.go 76.47% <40%> (-23.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f9233...addb5b8. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 21, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 21, 2018
@cez81
Copy link
Contributor

cez81 commented Oct 21, 2018

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 21, 2018
@jonasfranz jonasfranz merged commit 9458880 into go-gitea:master Oct 21, 2018
@jonasfranz jonasfranz added this to the 1.7.0 milestone Oct 21, 2018
@typeless typeless deleted the retry-load-test-fixtures branch April 3, 2019 05:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants