Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendor/go-sqlite3 #5133

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Update vendor/go-sqlite3 #5133

merged 2 commits into from
Oct 23, 2018

Conversation

typeless
Copy link
Contributor

@typeless typeless commented Oct 21, 2018 •
edited
Loading

Update vendor/github/mattn/go-sqlite3.

@typeless
Copy link
Contributor Author

@lunny Should I skip the changes of build tags for now?

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 21, 2018
@typeless typeless changed the title Add go-sqlite3 build tag 'sqlite_unlock_notify' Update go-sqlite3 and build tag 'sqlite_unlock_notify' Oct 21, 2018
@codecov-io
Copy link

codecov-io commented Oct 21, 2018 •
edited
Loading

Codecov Report

Merging #5133 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5133   +/-   ##
=======================================
  Coverage   37.48%   37.48%           
=======================================
  Files         309      309           
  Lines       45782    45782           
=======================================
  Hits        17161    17161           
- Misses      26158    26159    +1     
+ Partials     2463     2462    -1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_indexer.go 52.11% <0%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6759237...a4f0cd7. Read the comment docs.

@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 21, 2018
@typeless typeless force-pushed the update-vendor-go-sqlite3 branch 3 times, most recently from bb2ca0a to fe23f1d Compare October 21, 2018 05:36
@typeless typeless mentioned this pull request Oct 21, 2018
Merged
@typeless
Copy link
Contributor Author

Will update this PR when #5134 is merged.

@typeless
Copy link
Contributor Author

typeless commented Oct 21, 2018 •
edited
Loading

Will update this PR when #5134 is merged.

Done.

@lunny
Copy link
Member

lunny commented Oct 22, 2018

@typeless I will rebuild the CI serval times to see if there is still random failed. And should this resolve #2040 ?

@typeless
Copy link
Contributor Author

@lunny Yes

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 22, 2018
@typeless typeless changed the title Update go-sqlite3 and build tag 'sqlite_unlock_notify' Update vendor/go-sqlite3 Oct 23, 2018
@typeless
Copy link
Contributor Author

I split the PR into two. Now, this one is only for updating vendor/go-sqlite3. A later PR will update the build tags.

@typeless typeless mentioned this pull request Oct 23, 2018
Merged
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 23, 2018
@lunny lunny merged commit 2ce72d4 into go-gitea:master Oct 23, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 23, 2018
@typeless typeless deleted the update-vendor-go-sqlite3 branch April 3, 2019 05:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@typeless @codecov-io @lunny @sapk @techknowlogick @bkcsoft