Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly decide whether to use TLS in mailer's configuration #5024

Merged
merged 8 commits into from
Nov 26, 2018

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Oct 6, 2018

Fixes #4820

@adelowo adelowo changed the title Explicitly use tls for mailer Explicitly decide whether to TLS in mailer's configuration Oct 6, 2018
@codecov-io
Copy link

codecov-io commented Oct 6, 2018

Codecov Report

Merging #5024 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5024      +/-   ##
==========================================
+ Coverage   37.45%   37.45%   +<.01%     
==========================================
  Files         312      312              
  Lines       46510    46510              
==========================================
+ Hits        17419    17422       +3     
+ Misses      26599    26597       -2     
+ Partials     2492     2491       -1
Impacted Files Coverage Δ
modules/mailer/mailer.go 3.95% <0%> (+0.02%) ⬆️
modules/setting/setting.go 48.06% <0%> (-0.07%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce9a517...a393bd9. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2018
@adelowo adelowo changed the title Explicitly decide whether to TLS in mailer's configuration Explicitly decide whether to use TLS in mailer's configuration Oct 6, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 6, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 6, 2018
@lunny lunny added the type/enhancement An improvement of existing functionality label Oct 6, 2018
@lafriks
Copy link
Member

lafriks commented Oct 6, 2018

It should probably use default depending on port set to not break compatibility

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2018
@adelowo adelowo force-pushed the explicitly_use_tls_for_mailer branch from 4fd1d20 to 94a93ab Compare November 2, 2018 00:37
@adelowo
Copy link
Member Author

adelowo commented Nov 2, 2018

Sorry for not updating this on time. I have been a little busy this past 2 weeks.

I would be updating my other PRs before the start of next week

@techknowlogick
Copy link
Member

@adelowo no worries. We appreciate the time you are able to give.

@techknowlogick techknowlogick merged commit 3a1ed82 into go-gitea:master Nov 26, 2018
@adelowo adelowo deleted the explicitly_use_tls_for_mailer branch November 26, 2018 19:37
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mail module should add an option to explicitly decide using tls or not.
6 participants