Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail module should add an option to explicitly decide using tls or not. #4820

Closed
simonwu-os opened this issue Aug 29, 2018 · 0 comments · Fixed by #5024
Closed

Mail module should add an option to explicitly decide using tls or not. #4820

simonwu-os opened this issue Aug 29, 2018 · 0 comments · Fixed by #5024
Labels
type/enhancement An improvement of existing functionality
Milestone

Comments

@simonwu-os
Copy link

Dear All,
in the module gitea/modules/mailer/mailer.go, there is a fragment to decide it using tls or not.
isSecureConn := false
// Start TLS directly if the port ends with 465 (SMTPS protocol)
if strings.HasSuffix(port, "465") {
conn = tls.Client(conn, tlsconfig)
isSecureConn = true
}
It says that the port should suffix with '465'. we have a problem it, because we use a smtp which using the port 946 for tls connect. So I suggest add an option in the mail config to support tls connect explicitly.
Thanks very much.

@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 29, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 6, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants