Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation page ssh domain unavilable #499

Merged
merged 1 commit into from
Dec 27, 2016

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 27, 2016

On installation page, whatever you fill in the Domain(SSH), it will not fill into ssh clone URL. This will fix that and should be merged to release/v1.0 after merged. And this will also resolve #472

@lunny lunny added the type/bug label Dec 27, 2016
@lunny lunny added this to the 1.0.1 milestone Dec 27, 2016
@Bwko
Copy link
Member

Bwko commented Dec 27, 2016

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 27, 2016
@lunny lunny modified the milestones: 1.1.0, 1.0.1 Dec 27, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 27, 2016

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2016
@bkcsoft bkcsoft merged commit 7802699 into go-gitea:master Dec 27, 2016
@tboerger
Copy link
Member

LGTM

@lunny lunny added the backport/done All backports for this PR have been created label Dec 28, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Jan 3, 2017

This need to be fixed, see #506 (comment)
Not sure how I missed that 🙁

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I suggest the ssh button to generate ssh address when using js to get the current page host way.
4 participants