Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I suggest the ssh button to generate ssh address when using js to get the current page host way. #472

Closed
insionng opened this issue Dec 24, 2016 · 9 comments · Fixed by #499
Labels
type/enhancement An improvement of existing functionality
Milestone

Comments

@insionng
Copy link

This allows the correct host to be obtained by default without properly configuring the [server] ROOT_URL address.

@lunny lunny added this to the 1.1.0 milestone Dec 24, 2016
@lunny lunny added the type/enhancement An improvement of existing functionality label Dec 24, 2016
@lunny
Copy link
Member

lunny commented Dec 24, 2016

Thanks. Could you send a PR to gitea?

@tboerger
Copy link
Member

The ssh is not equal to the Web host, so this doesn't work. The value just needs to be exposed to the installer

@lunny
Copy link
Member

lunny commented Dec 24, 2016

He means after you install a new instance of gitea, ssh clone address' host is empty.

@tboerger
Copy link
Member

It's not empty, it just defaults to the wrong hostname.

@tboerger
Copy link
Member

The setting https://github.com/go-gitea/gitea/blob/master/conf/app.ini#L102 is responsible for the host displayed there.

@lunny
Copy link
Member

lunny commented Dec 25, 2016

So we need send a bug fix?

@tboerger
Copy link
Member

That's not a bug, it's simply not exposed on the installation wizard

@typeless
Copy link
Contributor

typeless commented Dec 27, 2016

The setting https://github.com/go-gitea/gitea/blob/master/conf/app.ini#L102 is responsible for the host displayed there.

@tboerger
Why is there an 's' after %(DOMAIN)?

I thought that is a supported interpolation syntax 😆

@tboerger
Copy link
Member

I thought that is a supported interpolation syntax 😆

That's how the ini lib implemented the interpolation ;)

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants