Disable issue/PR comment button given empty input

[kemzeb]

Given an empty issue/PR comment, the comment history would not be updated if the user were to submit it. Therefore, it would make since to just disable the comment button when the text editor is empty.

This is inline with what GitHub does when given empty text editor input.

[kemzeb]

I manually tested both issue/PR comments and they appear to work fine.

Before:

After:

[lafriks]

Usually disabling buttons is not good UX practice as users cannot know why it's disabled. It's better to disallow submitting form with error notification about what is missing/invalid to submit form

[kemzeb]

Usually disabling buttons is not good UX practice as users cannot know why it's disabled. It's better to disallow submitting form with error notification about what is missing/invalid to submit form

Thanks for the review! As I explained in the desc I followed how GitHub handles this case (though I'm not sure if they inform the user about why it's disabled and I'm unable to check ATM).

With that said, I do agree with you and will look into your approach when I get the time.

[wxiaoguang]

Usually disabling buttons is not good UX practice as users cannot know why it's disabled. It's better to disallow submitting form with error notification about what is missing/invalid to submit form

I do not think it is a must for this case. Everyone should know that empty content is not allowed to be submitted if the button is disabled.

And even more, it is quite hacky to add tooltip for a disabled element. So I prefer to go with this one, no more tooltip.

[delvh]

@wxiaoguang's approach sounds good

[lafriks]

Usually disabling buttons is not good UX practice as users cannot know why it's disabled. It's better to disallow submitting form with error notification about what is missing/invalid to submit form

I do not think it is a must for this case. Everyone should know that empty content is not allowed to be submitted if the button is disabled.

And even more, it is quite hacky to add tooltip for a disabled element. So I prefer to go with this one, no more tooltip.

I'm not suggesting to add tooltip to disabled button but to not disable button and when clicked inform user that comment content is required

[wxiaoguang]

I'm not suggesting to add tooltip to disabled button but to not disable button and when clicked inform user that comment content is required

I still prefer the current "disabled button" solution. The reason is:

• It has a intuitive UI feedback. But by using "informing after clicking", it actually misleads the users that "oh the form can be submitted" and they could only get the feedback at the second step (after the click).
• Injecting translation strings for a prompt message is still hacky in this case.
• At least, the "disabled button" is consistent with GitHub's form.