Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to "Write" tab when edit comment again #31445

Merged
merged 3 commits into from
Jun 22, 2024
Merged

Switch to "Write" tab when edit comment again #31445

merged 3 commits into from
Jun 22, 2024

Conversation

wxiaoguang
Copy link
Contributor

Fix #19031

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 21, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 21, 2024
@wxiaoguang wxiaoguang added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 and removed modifies/js labels Jun 21, 2024
@wxiaoguang wxiaoguang mentioned this pull request Jun 21, 2024
Closed
@wxiaoguang wxiaoguang changed the title Switch to "edit" tab when edit comment again Switch to "Write" tab when edit comment again Jun 21, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 22, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 22, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) June 22, 2024 09:22
@wxiaoguang wxiaoguang merged commit bda875b into go-gitea:main Jun 22, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 22, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 22, 2024
@wxiaoguang @GiteaBot
Switch to "Write" tab when edit comment again (go-gitea#31445)
0dd29e4 
Fix go-gitea#19031
@GiteaBot GiteaBot mentioned this pull request Jun 22, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jun 22, 2024
@wxiaoguang wxiaoguang deleted the fix-edit-tab branch June 22, 2024 09:42
@FWDekker
Copy link
Contributor

Thank you, @wxiaoguang!

wxiaoguang added a commit that referenced this pull request Jun 22, 2024
@GiteaBot @wxiaoguang
Switch to "Write" tab when edit comment again (#31445) (#31461)
8d60c7d 
Backport #31445 by wxiaoguang

Fix #19031

Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 24, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
490d6cd 
* giteaofficial/main:
  Disable issue/PR comment button given empty input (go-gitea#31463)
  Simplify 404/500 page (go-gitea#31409)
  Fix web notification icon not updated once you read all notifications (go-gitea#31447)
  Switch to "Write" tab when edit comment again (go-gitea#31445)
  Add simple JS init performance trace (go-gitea#31459)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Re-editing issue should open "Write", not "Preview"
5 participants
@wxiaoguang @FWDekker @lunny @delvh @GiteaBot