Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new issue/pr avatar #31419

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Fix new issue/pr avatar #31419

merged 2 commits into from
Jun 19, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jun 19, 2024 •
edited
Loading

The avatar on "New Issue" and "New Pull Request" pages was inconsistent. Removed the extra margin and the new CSS rules now use common parent <form id="#new-issue"> because .repository.new.issue is not present on pull request page.

Before:

Screenshot 2024-06-19 at 13 56 17 Screenshot 2024-06-19 at 13 54 02

After:

Screenshot 2024-06-19 at 13 54 16 Screenshot 2024-06-19 at 13 54 22

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 19, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 19, 2024
@silverwind silverwind added backport/v1.22 This PR should be backported to Gitea 1.22 type/bug topic/ui Change the appearance of the Gitea UI labels Jun 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 19, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 19, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) June 19, 2024 16:14
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 19, 2024
@techknowlogick techknowlogick merged commit 566d87b into go-gitea:main Jun 19, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 19, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 19, 2024
@silverwind silverwind deleted the newiss branch June 19, 2024 16:24
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 19, 2024
@silverwind @GiteaBot
Fix new issue/pr avatar (go-gitea#31419)
952de61 
The avatar on "New Issue" and "New Pull Request" pages was inconsistent.
Removed the extra margin and the new CSS rules now use common parent
`<form id="#new-issue">` because `.repository.new.issue` is not present
on pull request page.
@GiteaBot GiteaBot mentioned this pull request Jun 19, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jun 19, 2024
silverwind added a commit that referenced this pull request Jun 19, 2024
@GiteaBot @silverwind
Fix new issue/pr avatar (#31419) (#31424)
5c79c2b 
Backport #31419 by @silverwind

The avatar on "New Issue" and "New Pull Request" pages was inconsistent.
Removed the extra margin and the new CSS rules now use common parent
`<form id="#new-issue">` because `.repository.new.issue` is not present
on pull request page.

Before:

<img width="181" alt="Screenshot 2024-06-19 at 13 56 17"
src="https://github.com/go-gitea/gitea/assets/115237/5270d352-db5b-45b3-9d06-4790c17ae9b4">
<img width="213" alt="Screenshot 2024-06-19 at 13 54 02"
src="https://github.com/go-gitea/gitea/assets/115237/012f5607-aef0-4f48-90e3-8d4022480203">


After:

<img width="195" alt="Screenshot 2024-06-19 at 13 54 16"
src="https://github.com/go-gitea/gitea/assets/115237/e7590c66-3b28-4790-9970-33bd567eeb31">
<img width="212" alt="Screenshot 2024-06-19 at 13 54 22"
src="https://github.com/go-gitea/gitea/assets/115237/8e1cfede-614c-4cea-9af2-ada6da7a7361">

Co-authored-by: silverwind <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 20, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
4bc2d33 
* giteaofficial/main:
  Fix markdown math brackets render problem (go-gitea#31420)
  Reduce `air` verbosity (go-gitea#31417)
  Fix new issue/pr avatar (go-gitea#31419)
  Increase max length of org team names from 30 to 255 characters (go-gitea#31410)
silverwind added a commit to silverwind/gitea that referenced this pull request Jun 21, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into tsconfig
afa931e 
* origin/main: (21 commits)
  Fix deprecated Dockerfile ENV format (go-gitea#31450)
  README Badge maintenance (go-gitea#31441)
  Improve markdown textarea for indentation and lists (go-gitea#31406)
  Split common-global.js into separate files (go-gitea#31438)
  Fix the link for .git-blame-ignore-revs bypass (go-gitea#31432)
  Bump htmx to 2.0.0 (go-gitea#31413)
  Fix the wrong line number in the diff view page when expanded twice. (go-gitea#31431)
  Fix labels and projects menu overflow on issue page (go-gitea#31435)
  [Fix] Account Linking UpdateMigrationsByType  (go-gitea#31428)
  Fix markdown math brackets render problem (go-gitea#31420)
  Reduce `air` verbosity (go-gitea#31417)
  Fix new issue/pr avatar (go-gitea#31419)
  Increase max length of org team names from 30 to 255 characters (go-gitea#31410)
  [skip ci] Updated translations via Crowdin
  Refactor names (go-gitea#31405)
  Update JS dependencies, remove `eslint-plugin-jquery` (go-gitea#31402)
  Switch to upstream of `gorilla/feeds` (go-gitea#31400)
  Fix rendered wiki page link (go-gitea#31398)
  Refactor repo unit "disabled" check (go-gitea#31389)
  Refactor route path normalization (go-gitea#31381)
  ...
@charles7668 charles7668 mentioned this pull request Jun 27, 2024
Merged
silverwind pushed a commit that referenced this pull request Jun 27, 2024
@charles7668
Fix avatar radius problem on the new issue page (#31506)
d655ff1 
Close #31502

Related to #31419.

In this PR, the avatar width is set to 3em, but the height is not set,
so the image is not squared.

When object-fit is set to contain, it can't maintain the radius of the
image.

Result:

![圖片](https://github.com/go-gitea/gitea/assets/30816317/bceb98aa-b0f7-4753-bc8b-3b9c41dfd55a)
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 27, 2024
@charles7668 @GiteaBot
Fix avatar radius problem on the new issue page (go-gitea#31506)
710034b 
Close go-gitea#31502

Related to go-gitea#31419.

In this PR, the avatar width is set to 3em, but the height is not set,
so the image is not squared.

When object-fit is set to contain, it can't maintain the radius of the
image.

Result:

![圖片](https://github.com/go-gitea/gitea/assets/30816317/bceb98aa-b0f7-4753-bc8b-3b9c41dfd55a)
@GiteaBot GiteaBot mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silverwind @techknowlogick @wxiaoguang @GiteaBot