Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor names #31405

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Refactor names #31405

merged 2 commits into from
Jun 18, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jun 17, 2024 •
edited
Loading

Follow #31381 (review)

This PR only does "renaming":

  • Route should be Router (and chi router is also called "router")
  • Params should be PathParam (to distingush it from URL query param, and to match FormString)
  • Use lower case for private functions to avoid exposing or abusing

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 17, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jun 17, 2024
@wxiaoguang wxiaoguang mentioned this pull request Jun 17, 2024
Merged
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 17, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 18, 2024
@silverwind
Copy link
Member

silverwind commented Jun 18, 2024 •
edited
Loading

Likely needs a breaking label as it affects custom go templates. BTW I wouldn't call out such changes too prominently in the changelog as only a very small number of users even use custom go templates.

@wxiaoguang
Copy link
Contributor Author

Likely needs a breaking label as it affects custom go templates. BTW I wouldn't call out such changes too prominently in the changelog as only a very small number of users even use custom go templates.

No, it isn't breaking. No template is changed.

silverwind
silverwind approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, this is likely going to break a number of open PRs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2024
@wxiaoguang
Copy link
Contributor Author

I could help to resolve conflicts, just ping me if needed.

@wxiaoguang wxiaoguang merged commit 43c7a2e into go-gitea:main Jun 18, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 18, 2024
@wxiaoguang wxiaoguang deleted the refactor-names branch June 18, 2024 22:32
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 19, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5447ef0 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Refactor names (go-gitea#31405)
  Update JS dependencies, remove `eslint-plugin-jquery` (go-gitea#31402)
  Switch to upstream of `gorilla/feeds` (go-gitea#31400)
@delvh
Copy link
Member

delvh commented Jun 19, 2024

Likely needs a breaking label as it affects custom go templates. BTW I wouldn't call out such changes too prominently in the changelog as only a very small number of users even use custom go templates.

Technically, we don't consider breaking templates to be breaking as otherwise any PR modifying any template would be breaking

@silverwind
Copy link
Member

Likely needs a breaking label as it affects custom go templates. BTW I wouldn't call out such changes too prominently in the changelog as only a very small number of users even use custom go templates.

Technically, we don't consider breaking templates to be breaking as otherwise any PR modifying any template would be breaking

I meant renaming template helper functions and these were considered breaking in the past. But I misread the PR, it does not change any of them.

silverwind added a commit to silverwind/gitea that referenced this pull request Jun 21, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into tsconfig
afa931e 
* origin/main: (21 commits)
  Fix deprecated Dockerfile ENV format (go-gitea#31450)
  README Badge maintenance (go-gitea#31441)
  Improve markdown textarea for indentation and lists (go-gitea#31406)
  Split common-global.js into separate files (go-gitea#31438)
  Fix the link for .git-blame-ignore-revs bypass (go-gitea#31432)
  Bump htmx to 2.0.0 (go-gitea#31413)
  Fix the wrong line number in the diff view page when expanded twice. (go-gitea#31431)
  Fix labels and projects menu overflow on issue page (go-gitea#31435)
  [Fix] Account Linking UpdateMigrationsByType  (go-gitea#31428)
  Fix markdown math brackets render problem (go-gitea#31420)
  Reduce `air` verbosity (go-gitea#31417)
  Fix new issue/pr avatar (go-gitea#31419)
  Increase max length of org team names from 30 to 255 characters (go-gitea#31410)
  [skip ci] Updated translations via Crowdin
  Refactor names (go-gitea#31405)
  Update JS dependencies, remove `eslint-plugin-jquery` (go-gitea#31402)
  Switch to upstream of `gorilla/feeds` (go-gitea#31400)
  Fix rendered wiki page link (go-gitea#31398)
  Refactor repo unit "disabled" check (go-gitea#31389)
  Refactor route path normalization (go-gitea#31381)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wxiaoguang @silverwind @delvh @lunny @GiteaBot