-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix telegram webhook #29864
Merged
Merged
fix telegram webhook #29864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
approved these changes
Mar 17, 2024
wxiaoguang
approved these changes
Mar 17, 2024
wxiaoguang
reviewed
Mar 17, 2024
Could there be some test code in |
@wxiaoguang Added test |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 19, 2024
* giteaofficial/main: Fix missing error check of bufio.Scanner (go-gitea#29882) Remove unused error in graceful manager (go-gitea#29871) Migrate border and margin classes to Tailwind (go-gitea#29828) Only do counting when count_only=true for repo dashboard (go-gitea#29884) Editor error message misleading due to re-used key. (go-gitea#29859) [skip ci] Updated licenses and gitignores move some scripts from 'build' to 'tools' directory, misc refactors (go-gitea#29844) Fix missing code in the user profile (go-gitea#29865) Upgrade Go 1.22 and upgrade dependency (go-gitea#29869) Fix the wrong locale key of searching users (go-gitea#29868) fix telegram webhook (go-gitea#29864) Fix user id column case (go-gitea#29863) Avoid JS error on issue/pr list when logged out (go-gitea#29854) Refactor clone-panel styles (go-gitea#29861) Simplify README (go-gitea#29827) Load citation JS only when needed (go-gitea#29855) Fix semantic.json (go-gitea#29860) # Conflicts: # templates/repo/wiki/revision.tmpl # templates/repo/wiki/view.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/go
Pull requests that update Go code
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
topic/webhooks
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29837 which is a regression caused by https://github.com/go-gitea/gitea/pull/29145/files#diff-731445ee00f0f1bf2ff731f4f96ddcf51cdc53fd2faaf406eb3536fc292ea748L48. The line was probably removed by accident.