Load citation JS only when needed #29855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
reviewed
Mar 17, 2024
wxiaoguang
approved these changes
Mar 17, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Mar 17, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
wxiaoguang
reviewed
Mar 17, 2024
| updateUi(); | ||
| $('#cite-repo-button').on('click', async (e) => { | ||
| const dropdownBtn = e.target.closest('.ui.dropdown.button'); | ||
| dropdownBtn.classList.add('is-loading'); |
There was a problem hiding this comment.
Sidenote: for the worry about "some refactoring may break this logic", I have 2 ideas for it:
- Just leave it as-is. Because we have error-catch mechanism, so if it breaks, there should be immediate error reports on the UI (
dropdownBtn.xxxwill fail if it is null) - Add a helper function like
closestVisibleElem(), maybe it could be useful for some more cases.
There was a problem hiding this comment.
.closest is straightforward, I think such a helper would only very rarely be useful.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 19, 2024
* giteaofficial/main: Fix missing error check of bufio.Scanner (go-gitea#29882) Remove unused error in graceful manager (go-gitea#29871) Migrate border and margin classes to Tailwind (go-gitea#29828) Only do counting when count_only=true for repo dashboard (go-gitea#29884) Editor error message misleading due to re-used key. (go-gitea#29859) [skip ci] Updated licenses and gitignores move some scripts from 'build' to 'tools' directory, misc refactors (go-gitea#29844) Fix missing code in the user profile (go-gitea#29865) Upgrade Go 1.22 and upgrade dependency (go-gitea#29869) Fix the wrong locale key of searching users (go-gitea#29868) fix telegram webhook (go-gitea#29864) Fix user id column case (go-gitea#29863) Avoid JS error on issue/pr list when logged out (go-gitea#29854) Refactor clone-panel styles (go-gitea#29861) Simplify README (go-gitea#29827) Load citation JS only when needed (go-gitea#29855) Fix semantic.json (go-gitea#29860) # Conflicts: # templates/repo/wiki/revision.tmpl # templates/repo/wiki/view.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the citation js would load every time when opening a citable repo. Now it only loads when the user clicks the button for it. The loading state is representend with a spinner on the button:
Diff ist best viewed with whitespace hidden.