Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show third-party JS errors in production builds #29303

Merged
merged 11 commits into from
Feb 22, 2024
Merged

Don't show third-party JS errors in production builds #29303

merged 11 commits into from
Feb 22, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Feb 21, 2024 •
edited
Loading

So we don't get issues like #29080 and #29273 any more. Only active in production builds, in non-production the errors will still show.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 21, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2024
@silverwind silverwind changed the title Don't show global JS errors in production Don't show global JS errors in production builds Feb 21, 2024
@silverwind silverwind added the backport/v1.21 This PR should be backported to Gitea 1.21 label Feb 21, 2024
@silverwind silverwind changed the title Don't show global JS errors in production builds Don't show third-party JS errors Feb 21, 2024
@silverwind silverwind changed the title Don't show third-party JS errors Don't show third-party JS errors in production builds Feb 21, 2024
@silverwind silverwind added the type/enhancement An improvement of existing functionality label Feb 22, 2024
@wxiaoguang
Copy link
Contributor

I would suggest to check window.config.runModeIsProd and maybe also check whether current user is admin (in case the site admin tries to help users to figure out why "something doesn't work")

@silverwind
Copy link
Member Author

runModeIsProd seems good, but the admin thing I wouldn't do, it's too strange behaviour do so something different per user role and admins can also have broken extensions installed.

@silverwind
Copy link
Member Author

Now uses runModeIsProd.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 22, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 22, 2024
delvh
delvh approved these changes Feb 22, 2024
View reviewed changes
web_src/js/bootstrap.js Outdated Show resolved Hide resolved
@delvh delvh self-requested a review February 22, 2024 16:49
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 22, 2024
@silverwind silverwind enabled auto-merge (squash) February 22, 2024 21:17
@silverwind
Copy link
Member Author

Merging as I think @Delv would approve latest change

@silverwind silverwind merged commit 532da5e into go-gitea:main Feb 22, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 22, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 22, 2024
@silverwind @GiteaBot
Don't show third-party JS errors in production builds (go-gitea#29303)
0f524d0 
So we don't get issues like
go-gitea#29080 and
go-gitea#29273 any more. Only active in
[production
builds](https://webpack.js.org/guides/production/#specify-the-mode), in
non-production the errors will still show.
@GiteaBot GiteaBot mentioned this pull request Feb 22, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Feb 22, 2024
silverwind added a commit that referenced this pull request Feb 22, 2024
@GiteaBot @silverwind
Don't show third-party JS errors in production builds (#29303) (#29333)
6ca8cb5 
Backport #29303 by @silverwind

So we don't get issues like
#29080 and
#29273 any more. Only active in
[production
builds](https://webpack.js.org/guides/production/#specify-the-mode), in
non-production the errors will still show.

Co-authored-by: silverwind <[email protected]>
@delvh
Copy link
Member

delvh commented Feb 22, 2024

I assume you mean me, and yes, I already approved

@silverwind silverwind deleted the proderr branch February 22, 2024 22:41
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 23, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d1e6961 
* giteaofficial/main:
  Start to migrate from `util.OptionalBool` to `optional.Option[bool]` (go-gitea#29329)
  Add slow SQL query warning (go-gitea#27545)
  Unify organizations header (go-gitea#29248)
  Frontport changelogs of minor releases (go-gitea#29337)
  Support SAML authentication (go-gitea#25165)
  Upgrade to fabric 6 (go-gitea#29334)
  Don't show third-party JS errors in production builds (go-gitea#29303)
  Remove bountysource (go-gitea#29330)
  Remove unnecessary "Str2html" modifier from templates (go-gitea#29319)
  Ignore the linux anchor point to avoid linux migrate failure (go-gitea#29295)
  Remove jQuery from the repo commit functions (go-gitea#29230)
  Remove unnecessary "Safe" modifier from templates (go-gitea#29318)
  Remove jQuery from the image pasting functionality (go-gitea#29324)
  Improve the `issue_comment` workflow trigger event (go-gitea#29277)
  Properly migrate automatic merge GitLab comments (go-gitea#27873)
  Refactor cmd setup and remove deadcode (go-gitea#29313)
  small cache when get user id on interation (go-gitea#29296)
  Discard unread data of `git cat-file` (go-gitea#29297)
  Don't install playwright twice (go-gitea#29302)

# Conflicts:
#	templates/home.tmpl
@wxiaoguang wxiaoguang mentioned this pull request Feb 27, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@6543 6543 6543 approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @wxiaoguang @delvh @6543 @GiteaBot