Improve the issue_comment workflow trigger event

[Zettat123]

Fix #29175
Replace #29207

This PR makes some improvements to the issue_comment workflow trigger event.

1. Fix the bug that pull requests cannot trigger issue_comment workflows
2. Previously the issue_comment event only supported the created activity type. This PR adds support for the missing edited and deleted activity types.
3. Some events (including issue_comment, issues, etc. ) only trigger workflows that belong to the workflow file on the default branch. This PR introduces the IsDefaultBranchWorkflow function to check for these events.

[hwaastad]

Would very much like this to be merged. Makes it possible to utilize branch-deploy action

[lunny]

I think there are 3 kinds of branches. Default branch, base branch and current branch.

[Zettat123]

I think there are 3 kinds of branches. Default branch, base branch and current branch.

For those trigger events that should trigger workflows on the base branch (like pull_request_target) or the current branch (like push), we need to call WithRef to set the ref manually. If the event is related to pull request, its ref will be set in WithPullRequest.

gitea/services/actions/notifier_helper.go

Lines 86 to 89 in 22b8de8

	func (input *notifyInput) WithRef(ref string) *notifyInput {
	input.Ref = ref
	return input
	}

For those trigger events that should only trigger workflows on the default branch, the ref can be empty and it will fall back to the default branch.

In this PR, if a event cannot pass the check of IsDefaultBranchWorkflow and has an empty ref, its ref will fall back to the default branch and there will be a warn log.

[yp05327]

Maybe it is better to merge similar codes of UpdateComment and DeleteComment, like notifyIssueChange.

gitea/services/actions/notifier.go

Lines 178 to 219 in 182b9c1

	func notifyIssueChange(ctx context.Context, doer *user_model.User, issue *issues_model.Issue, event webhook_module.HookEventType, action api.HookIssueAction) {
	var err error
	if err = issue.LoadRepo(ctx); err != nil {
	log.Error("LoadRepo: %v", err)
	return
	}
	if err = issue.LoadPoster(ctx); err != nil {
	log.Error("LoadPoster: %v", err)
	return
	}
	if issue.IsPull {
	if err = issue.LoadPullRequest(ctx); err != nil {
	log.Error("loadPullRequest: %v", err)
	return
	}
	newNotifyInputFromIssue(issue, event).
	WithDoer(doer).
	WithPayload(&api.PullRequestPayload{
	Action: action,
	Index: issue.Index,
	PullRequest: convert.ToAPIPullRequest(ctx, issue.PullRequest, nil),
	Repository: convert.ToRepo(ctx, issue.Repo, access_model.Permission{AccessMode: perm_model.AccessModeNone}),
	Sender: convert.ToUser(ctx, doer, nil),
	}).
	WithPullRequest(issue.PullRequest).
	Notify(ctx)
	return
	}
	permission, _ := access_model.GetUserRepoPermission(ctx, issue.Repo, issue.Poster)
	newNotifyInputFromIssue(issue, event).
	WithDoer(doer).
	WithPayload(&api.IssuePayload{
	Action: action,
	Index: issue.Index,
	Issue: convert.ToAPIIssue(ctx, issue),
	Repository: convert.ToRepo(ctx, issue.Repo, permission),
	Sender: convert.ToUser(ctx, doer, nil),
	}).
	Notify(ctx)
	}

[Zettat123]

Maybe it is better to merge similar codes of UpdateComment and DeleteComment, like notifyIssueChange.

gitea/services/actions/notifier.go

Lines 178 to 219 in 182b9c1

	func notifyIssueChange(ctx context.Context, doer *user_model.User, issue *issues_model.Issue, event webhook_module.HookEventType, action api.HookIssueAction) {
	var err error
	if err = issue.LoadRepo(ctx); err != nil {
	log.Error("LoadRepo: %v", err)
	return
	}
	if err = issue.LoadPoster(ctx); err != nil {
	log.Error("LoadPoster: %v", err)
	return
	}
	if issue.IsPull {
	if err = issue.LoadPullRequest(ctx); err != nil {
	log.Error("loadPullRequest: %v", err)
	return
	}
	newNotifyInputFromIssue(issue, event).
	WithDoer(doer).
	WithPayload(&api.PullRequestPayload{
	Action: action,
	Index: issue.Index,
	PullRequest: convert.ToAPIPullRequest(ctx, issue.PullRequest, nil),
	Repository: convert.ToRepo(ctx, issue.Repo, access_model.Permission{AccessMode: perm_model.AccessModeNone}),
	Sender: convert.ToUser(ctx, doer, nil),
	}).
	WithPullRequest(issue.PullRequest).
	Notify(ctx)
	return
	}
	permission, _ := access_model.GetUserRepoPermission(ctx, issue.Repo, issue.Poster)
	newNotifyInputFromIssue(issue, event).
	WithDoer(doer).
	WithPayload(&api.IssuePayload{
	Action: action,
	Index: issue.Index,
	Issue: convert.ToAPIIssue(ctx, issue),
	Repository: convert.ToRepo(ctx, issue.Repo, permission),
	Sender: convert.ToUser(ctx, doer, nil),
	}).
	Notify(ctx)
	}

Good idea. Done in 9bc944c

[github-actions]

Automatically locked because of our CONTRIBUTING guidelines