-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hide/Show all checks
button to commit status check
#26284
Conversation
If there's only one commit status, there's no scrollbar. But if I click Edited: |
And there's two border lines here. 🤔 Edited: |
Yeah, this is step two, and I wish I can also fix #25279 in step two. (But I'm not good at frontend 😢) Edited: |
Can I change the max-width in L9 directly? It seems that this comes from tippy, not sure whether we can change it manually. It seems that it is not correct, it should be at least |
It is a original tippy.js rule: It seems to be a way to prevent a tippy instances from becoming wider than the page, and therefore go partially off-screen. It should not influence such dropdowns that are not nearly as wide as the page ( I think your issue is related to something different than that rule. |
Co-authored-by: delvh <[email protected]>
Co-authored-by: delvh <[email protected]>
Co-authored-by: delvh <[email protected]>
37006a2
to
e8ddbc9
Compare
It's right in the PR page but not in the popup because of the missing parent class. |
It's not related to Clarifying the root problem would always help the code quality. |
We should replace it with |
14c9688
to
46e528b
Compare
46e528b
to
a5f5953
Compare
The background color of |
Why not use |
We can do this for the Edit: done in 5b8a735. |
@wxiaoguang unblock? |
* upstream/main: Refactor Find Sources and fix bug when view a user who belongs to an unactive auth source (go-gitea#27798) [skip ci] Updated translations via Crowdin Add `Hide/Show all checks` button to commit status check (go-gitea#26284) Fix http protocol auth (go-gitea#27875) Display issue task list on project cards (go-gitea#27865) Reduce margin/padding on flex-list items and divider (go-gitea#27872)
) Step one for a GitHub like commit status check ui: ![image](https://github.com/go-gitea/gitea/assets/18380374/22953b88-1f91-4d19-bc57-ad92d33fa11f) ![image](https://github.com/go-gitea/gitea/assets/18380374/78572a49-c9b0-472b-86a8-8293197e807b) ![image](https://github.com/go-gitea/gitea/assets/18380374/bc5c8d1c-2ab5-4b03-b8c6-20c34b86d856) Step two: ![image](https://github.com/go-gitea/gitea/assets/18380374/938b359e-8823-4192-b82d-55fa40b986fd) ![image](https://github.com/go-gitea/gitea/assets/18380374/2de5bb8f-40f5-462a-8d6d-bac13a32bc2a) The design now will list all commit status checks which takes too much space. This is a pre-improve for go-gitea#26247 --------- Co-authored-by: delvh <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
Step one for a GitHub like commit status check ui:
![image](https://private-user-images.githubusercontent.com/18380374/257753438-22953b88-1f91-4d19-bc57-ad92d33fa11f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwMDY1NDYsIm5iZiI6MTcyNDAwNjI0NiwicGF0aCI6Ii8xODM4MDM3NC8yNTc3NTM0MzgtMjI5NTNiODgtMWY5MS00ZDE5LWJjNTctYWQ5MmQzM2ZhMTFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDE4MzcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ4NTE0ZjYwYmQ1ZjMwNGUxOTczZTc2NDBlZTQxOTI3MDQyYzczZTY1Y2ZkNDJlMTJlY2IyMjk0YTRiMTY2M2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.CdUbtYCGxYEfMM-20NR3L_Wb8XJFBkDUrIyXn_FPs50)
![image](https://private-user-images.githubusercontent.com/18380374/257753964-78572a49-c9b0-472b-86a8-8293197e807b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwMDY1NDYsIm5iZiI6MTcyNDAwNjI0NiwicGF0aCI6Ii8xODM4MDM3NC8yNTc3NTM5NjQtNzg1NzJhNDktYzliMC00NzJiLTg2YTgtODI5MzE5N2U4MDdiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDE4MzcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzZDg2MzAwZDA2ZjI3ODMxZjJiODIyODhmOWRkOTVjOTY1YzVhODI0Nzk0YjM0YjlmYjIwNGNhYzg2YmI2NTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.15VfnojTjPzGAos4OCWhOjjgo2zvK3MKCKE75bRc9yE)
![image](https://private-user-images.githubusercontent.com/18380374/257754032-bc5c8d1c-2ab5-4b03-b8c6-20c34b86d856.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwMDY1NDYsIm5iZiI6MTcyNDAwNjI0NiwicGF0aCI6Ii8xODM4MDM3NC8yNTc3NTQwMzItYmM1YzhkMWMtMmFiNS00YjAzLWI4YzYtMjBjMzRiODZkODU2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDE4MzcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWExNTVjY2I2YmMyMTE3OGVmZWUxY2VhODhkMTkxZjY3NzRlYjc0ZTEzNjk5OTJkMTE5ZGFjMDNiMzRhNDkzMDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.6bQIsmxT748_zpnQ1YsJqxJTUHP6kClHWhbOltCLH0A)
Step two:
![image](https://private-user-images.githubusercontent.com/18380374/258016548-938b359e-8823-4192-b82d-55fa40b986fd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwMDY1NDYsIm5iZiI6MTcyNDAwNjI0NiwicGF0aCI6Ii8xODM4MDM3NC8yNTgwMTY1NDgtOTM4YjM1OWUtODgyMy00MTkyLWI4MmQtNTVmYTQwYjk4NmZkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDE4MzcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ1OGI1OGU3ZmFjNzY1YjBmMjlhZWU4ZmQwYmVmZjM1ZGY2MTI1YmI3N2JjZDg4ZDk4ODNjOGNkYTkxYzNjNWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Y0-1XPDiSog_Y6UfGttFpMMkCUTUpLs4aZ2z8jqxxSc)
![image](https://private-user-images.githubusercontent.com/18380374/258016587-2de5bb8f-40f5-462a-8d6d-bac13a32bc2a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwMDY1NDYsIm5iZiI6MTcyNDAwNjI0NiwicGF0aCI6Ii8xODM4MDM3NC8yNTgwMTY1ODctMmRlNWJiOGYtNDBmNS00NjJhLThkNmQtYmFjMTNhMzJiYzJhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDE4MzcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE3Y2JjMjg3NTA5ZjJjMWQ5MDQwNmU2NGRiNTEyOWRiNTQ3NGEyOGZiYzJlZmYxZTNkMGU0OTRhMzk0NzhlMDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bJB-W1yQEJ4ZC0TtE5Ln5N8dE8FXoy63m9rCymXlhCk)
The design now will list all commit status checks which takes too much space.
This is a pre-improve for #26247