-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After hiding and unhiding commit checks, there are only four checks available #27928
Comments
The scroll bar of these commit lists sometimes messes with the scroll bar of the whole web page. Though failed to find a way to steadily reproduce it. |
Perhaps we should not confine the height. Lines 3082 to 3086 in 8557a94
|
-> Fix the overflow style for "Hide all checks" #27932 |
#27932 changes it to 6 visible items. |
silverwind
added a commit
that referenced
this issue
Nov 7, 2023
Fix #27928 --------- Co-authored-by: silverwind <[email protected]>
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this issue
Jan 17, 2024
Fix go-gitea#27928 --------- Co-authored-by: silverwind <[email protected]>
silverwind
added a commit
to silverwind/gitea
that referenced
this issue
Feb 20, 2024
Fix go-gitea#27928 --------- Co-authored-by: silverwind <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
take https://gitea.com/xorm/xorm/pulls/2364 for example.
This PR has eight checks. After hiding and unhiding commit checks, there are only four checks on the web page.
Regression of #26284
cc @yp05327
Screenshots
Before:
![before](https://private-user-images.githubusercontent.com/70063547/280619231-f9307d34-9fac-4725-a1bd-c02a5c599dbd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwMTMwMTUsIm5iZiI6MTcyNDAxMjcxNSwicGF0aCI6Ii83MDA2MzU0Ny8yODA2MTkyMzEtZjkzMDdkMzQtOWZhYy00NzI1LWExYmQtYzAyYTVjNTk5ZGJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDIwMjUxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFmOTMwNDIxNzhkYTU0ODc4Mzk4OGY3OTY4ZmFmNWQ5MTIyNTgyMjU0N2IzMjU2NTQ2N2I2MmZiZmY4NzgxNTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.IQDUs5UVY0n6UWWPh-rx_ZC1WM9TN57VaVYjmmxDcGI)
![after](https://private-user-images.githubusercontent.com/70063547/280619327-c9ce519a-7964-470f-aa91-8a5f8754affd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwMTMwMTUsIm5iZiI6MTcyNDAxMjcxNSwicGF0aCI6Ii83MDA2MzU0Ny8yODA2MTkzMjctYzljZTUxOWEtNzk2NC00NzBmLWFhOTEtOGE1Zjg3NTRhZmZkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDIwMjUxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWViNWE1ODdmNjExZGU1ZGYzYTZjZjI3YzE4MGJiMDNlMTgyYzliYWM1NmM3ZmI4MDg5NzllYjM0YjRhZDJlYTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ONyliJKOiiFol4pOJTc0FP_GCb1kND5qGd5EB9d6gLs)
After:
Gitea Version
current main
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
No response
Browser Version
none
The text was updated successfully, but these errors were encountered: