-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor improve NoBetterThan #26126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
lunny
reviewed
Jul 25, 2023
silverwind
approved these changes
Jul 25, 2023
yp05327
reviewed
Jul 26, 2023
Co-authored-by: yp05327 <[email protected]>
wolfogre
approved these changes
Jul 26, 2023
Thanks @CaiCandong for the unit test cases. Appreciated your efforts. 💯 |
puni9869
reviewed
Jul 26, 2023
Co-authored-by: puni9869 <[email protected]>
puni9869
reviewed
Jul 26, 2023
…o impove-NoBetterThan
auto-merge was automatically disabled
July 26, 2023 05:41
Head branch was pushed to by a user without write access
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 28, 2023
* giteaofficial/main: (21 commits) improve unit test for caching (go-gitea#26185) Render plaintext task list items for markdown files (go-gitea#26186) Add tooltip to describe LFS table column and color `delete LFS file` button red (go-gitea#26181) Show branches and tags that contain a commit (go-gitea#25180) Release attachments duplicated check (go-gitea#26176) Calculate MAX_WORKERS default value by CPU number (go-gitea#26177) Fixing redirection issue for logged-in users (go-gitea#26105) Update govulncheck, fix typo (go-gitea#26168) Fix handling of plenty Nuget package versions (go-gitea#26075) Fix typos in Contributing.md (go-gitea#26170) Disable download action logs button when there's no logs (go-gitea#26114) Re-add static images to docs (go-gitea#26167) Update email-setup.en-us.md (go-gitea#26068) Improve display of Labels/Projects/Assignees sort options (go-gitea#25886) Fix wrong branch name in rename branch modal (go-gitea#26146) Doc update swagger doc for POST /orgs/{org}/teams (go-gitea#26155) Fix UI regression of asciinema player (go-gitea#26159) refactor improve NoBetterThan (go-gitea#26126) Update Chinese documents (go-gitea#26139) Fix bugs in LFS meta garbage collection (go-gitea#26122) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoBetterThan
function can only handle comparisons between "pending," "success," "error," and "failure." For any other comparison, we directly return false. This prevents logic errors like the one in Fix wrong commit status in web ui #26121.NoBetterThan
function should also avoid making incomparable calls.