-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing redirection issue for logged-in users #26105
Conversation
@wxiaoguang need your feedback for this change. |
I haven't understood why this change works. In my mind, the straight fix could be:
|
Thats what I thought |
Signed-off-by: cassiozareck <[email protected]>
d5d6ba2
to
22dac0b
Compare
I haven't thought about it before, but your suggestion makes a lot more sense than changing the middleware itself. I've updated the PR accordingly. Now, I've moved the login route outside of the reqSignOut middleware and discarded the old changes. The auth.SignIn route handler now checks if the user is logged in. If the user is logged in, it redirects them. If the URL doesn't have the redirect_to parameter, it simply redirects to the / route. This is useful in scenarios where the user wants to access the redirect page only if they're logged in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, overall it looks good to me, while I think the "POST" method should be kept in the "reqSignOut"
Thanks cassiozareck for these changes. 💯 |
I tried that first but the login wasn't being saved after login probably because it expects the user should had first signed out to save the post login. |
Sorry maybe I misunderstood the problem. If "SignInPost" also needs to handle "redirect_to", IMO it needs a slightly different approach to keep the old behavior, I will try to figure it out. |
* giteaofficial/main: (21 commits) improve unit test for caching (go-gitea#26185) Render plaintext task list items for markdown files (go-gitea#26186) Add tooltip to describe LFS table column and color `delete LFS file` button red (go-gitea#26181) Show branches and tags that contain a commit (go-gitea#25180) Release attachments duplicated check (go-gitea#26176) Calculate MAX_WORKERS default value by CPU number (go-gitea#26177) Fixing redirection issue for logged-in users (go-gitea#26105) Update govulncheck, fix typo (go-gitea#26168) Fix handling of plenty Nuget package versions (go-gitea#26075) Fix typos in Contributing.md (go-gitea#26170) Disable download action logs button when there's no logs (go-gitea#26114) Re-add static images to docs (go-gitea#26167) Update email-setup.en-us.md (go-gitea#26068) Improve display of Labels/Projects/Assignees sort options (go-gitea#25886) Fix wrong branch name in rename branch modal (go-gitea#26146) Doc update swagger doc for POST /orgs/{org}/teams (go-gitea#26155) Fix UI regression of asciinema player (go-gitea#26159) refactor improve NoBetterThan (go-gitea#26126) Update Chinese documents (go-gitea#26139) Fix bugs in LFS meta garbage collection (go-gitea#26122) ...
This PR addresses an issue where logged-in users get redirected to the homepage when trying to access a URL with the redirect_to parameter. The issue was traced back to a middleware function in services/auth/middleware.go that redirects logged-in users to the homepage. This function didn't account the redirect_to parameter.
The fix modifies the middleware function to check for this case and redirect the user to the specified URL instead of the homepage.
Closes: #26005