-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use git.HOME_PATH for Git HOME directory #20114
Conversation
534960b
to
7f4b689
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Code L-G-T-M. Just wondering if it would be a problem that the directory already exists but permissions cannot be changed? Scenario in mind: It's a mount point from a Kubernetes pod already having correct permissions but changing them is not possible unless running as root. Is there a compiled executable I can use? I have issues with dependency installation and cannot compile/test right now. Edit: add dashes to magic abbreviation. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I will hide some unrelated comments (GitHub "bug") above 😊
I think there will be no problem, it works like other directories like "avatar" / "repo-archive", etc, created and used. The permissions are likely not necessary to be changed at the moment. But it's still good to do confirmation for different environments. If the gnupg requires some special permissions, then it could be redirected to another directory, like the GNUPGHOME discussed before. This PR is almost ready for review. There is one thing that I am uncertain, |
a6f33a2
to
780e858
Compare
c655e1a
to
701fa70
Compare
Some documents need to be updated, otherwise LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for our discuss about documents
Before, in go-gitea#19732, the old home directory is not correct. This PR introduces a new config option for git home: git.HOME_PATH, which is default to %(APP_DATA_PATH)/home And pass env GNUPGHOME to git command, force Gitea to use a stable GNUPGHOME directory
Before, in #19732, the old home directory is not correct. This PR introduces a new config option for git home: git.HOME_PATH, which is default to %(APP_DATA_PATH)/home And pass env GNUPGHOME to git command, force Gitea to use a stable GNUPGHOME directory
* giteaoffical/main: Implement sync push mirror on commit (go-gitea#19411) Use git.HOME_PATH for Git HOME directory (go-gitea#20114)
* Add git.HOME_PATH * add legacy file check * Apply suggestions from code review Co-authored-by: zeripath <[email protected]> * pass env GNUPGHOME to git command, move the existing .gitconfig to new home, make the fix for 1.17rc more clear. * set git.HOME_PATH for docker images to default HOME * Revert "set git.HOME_PATH for docker images to default HOME" This reverts commit f120101. * force Gitea to use a stable GNUPGHOME directory * extra check to ensure only process dir or symlink for legacy files * refactor variable name * The legacy dir check (for 1.17-rc1) could be removed with 1.18 release, since users should have upgraded from 1.17-rc to 1.17-stable * Update modules/git/git.go Co-authored-by: Steven Kriegler <[email protected]> * remove initFixGitHome117rc * Update git.go * Update docs/content/doc/advanced/config-cheat-sheet.en-us.md Co-authored-by: zeripath <[email protected]> Co-authored-by: 6543 <[email protected]> Co-authored-by: Steven Kriegler <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
* Add git.HOME_PATH * add legacy file check * Apply suggestions from code review Co-authored-by: zeripath <[email protected]> * pass env GNUPGHOME to git command, move the existing .gitconfig to new home, make the fix for 1.17rc more clear. * set git.HOME_PATH for docker images to default HOME * Revert "set git.HOME_PATH for docker images to default HOME" This reverts commit f120101. * force Gitea to use a stable GNUPGHOME directory * extra check to ensure only process dir or symlink for legacy files * refactor variable name * The legacy dir check (for 1.17-rc1) could be removed with 1.18 release, since users should have upgraded from 1.17-rc to 1.17-stable * Update modules/git/git.go Co-authored-by: Steven Kriegler <[email protected]> * remove initFixGitHome117rc * Update git.go * Update docs/content/doc/advanced/config-cheat-sheet.en-us.md Co-authored-by: zeripath <[email protected]> Co-authored-by: 6543 <[email protected]> Co-authored-by: Steven Kriegler <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
* Add git.HOME_PATH * add legacy file check * Apply suggestions from code review Co-authored-by: zeripath <[email protected]> * pass env GNUPGHOME to git command, move the existing .gitconfig to new home, make the fix for 1.17rc more clear. * set git.HOME_PATH for docker images to default HOME * Revert "set git.HOME_PATH for docker images to default HOME" This reverts commit f120101. * force Gitea to use a stable GNUPGHOME directory * extra check to ensure only process dir or symlink for legacy files * refactor variable name * The legacy dir check (for 1.17-rc1) could be removed with 1.18 release, since users should have upgraded from 1.17-rc to 1.17-stable * Update modules/git/git.go Co-authored-by: Steven Kriegler <[email protected]> * remove initFixGitHome117rc * Update git.go * Update docs/content/doc/advanced/config-cheat-sheet.en-us.md Co-authored-by: zeripath <[email protected]> Co-authored-by: 6543 <[email protected]> Co-authored-by: Steven Kriegler <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Gitea 1.17.0 changed the Gitea user's home directory. See: go-gitea/gitea#20114 go-gitea/gitea#19732
This PR follows:
As discussed in discord, it seems that it
is preferred toshould use a separate dir for git home.This PR introduces a new config option: git.HOME_PATH, which is default to %(APP_DATA_PATH)/home