If a SIGNING_KEY is specified in the config but not loaded, no error is printed to the log #20594
Labels
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
type/proposal
The new feature has not been accepted yet but needs to be discussed first.
Feature Description
We upgraded from 1.16.9 to 1.17.0 this weekend, and the changes from #20114 caused our Gitea-signed commits to start showing as unsigned; we didn't see any release notes that something had changed here. gitea.log contained this error only after trying to load a repo page that should have shown signed commits:
but we did not understand that that meant "your config specifies a SIGNING_KEY, but we couldn't find it when we tried to load it up." If there is any way to add an explicit error on startup to this effect, it would greatly help others caught in the migration to 1.17.0 who didn't see the new notice at https://docs.gitea.io/en-us/signing/#signing_key. Something along these lines would be very helpful:
Screenshots
No response
The text was updated successfully, but these errors were encountered: