-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make notification bell more prominent on mobile #20108
Conversation
So for non-login, it's a blank in the right-top corner. |
Hmm ... it seems not feasible. The mobile layout and desktop layout is different. |
How about put the smallbell middle? |
Looks fine to me. Or make the bell right-aligned(beside the menu), either is fine to me. |
Codecov Report
@@ Coverage Diff @@
## main #20108 +/- ##
=======================================
Coverage ? 46.94%
=======================================
Files ? 972
Lines ? 134536
Branches ? 0
=======================================
Hits ? 63164
Misses ? 63630
Partials ? 7742 Continue to review full report at Codecov.
|
conflict ? |
Yes, please resolve the conflicts. |
Solved |
LGTM |
…itea#20236, go-gitea#20251) Backport go-gitea#20108 Backport go-gitea#20236 Backport go-gitea#20251 Make notification bell more prominent on mobile Co-authored-by: Andrew Thornton <[email protected]> Co-authored-by: Tyrone Yeh <[email protected]> Signed-off-by: Andrew Thornton <[email protected]>
Unfortunately there is a bug in go-gitea#20108 where the translation call was not updated to use `.locale` from `.i18n`. This PR updates the template to use `.locale`. Signed-off-by: Andrew Thornton <[email protected]>
Unfortunately there is a bug in #20108 where the translation call was not updated to use `.locale` from `.i18n`. This PR updates the template to use `.locale`. Signed-off-by: Andrew Thornton <[email protected]>
* upstream/main: Modify milestone search keywords to be case insensitive (go-gitea#20266) Fix toolip on mobile notification bell (go-gitea#20270) Allow RSA 2047 bit keys (go-gitea#20272) Refix notification bell placement (go-gitea#20251) Bump mermaid from 9.1.1 to 9.1.2 (go-gitea#20256) EscapeFilter the group dn membership (go-gitea#20200) Only show Followers that current user can access (go-gitea#20220) Init popup for new code comment (go-gitea#20234) Bypass Firefox (iOS) bug (go-gitea#20244) Adjust max-widths for the repository file table (go-gitea#20243) Display full name (go-gitea#20171) Adjust class for mobile has the problem of double small bells (go-gitea#20236) Adjust template for go-gitea#20069 smallbell (go-gitea#20108) Add integration tests for the Gitea migration form (go-gitea#20121) Allow dev i18n to be more concurrent (go-gitea#20159) Allow enable LDAP source and disable user sync via CLI (go-gitea#20206)
…) (#20269) Backport #20108 Backport #20236 Backport #20251 Make notification bell more prominent on mobile Co-authored-by: Andrew Thornton <[email protected]> Co-authored-by: Tyrone Yeh <[email protected]> Signed-off-by: Andrew Thornton <[email protected]>
* Adjust template for go-gitea#20069 smallbell * Adjust notification Unread Count variable to global and count bell position with mobile * Adjust bell icon style * Adjust smallbell to middle * Avoid using inline styles * move notificationUnreadCount to a general code block, reduce changed lines * Solved conflicts Co-authored-by: wxiaoguang <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: 6543 <[email protected]>
Unfortunately there is a bug in go-gitea#20108 where the translation call was not updated to use `.locale` from `.i18n`. This PR updates the template to use `.locale`. Signed-off-by: Andrew Thornton <[email protected]>
- Since go-gitea#20108 we have two version of the notification bell, one for mobile the other for non-mobile. However the code only accounts for one notification count and thus was only updating the non-mobile one. - This code fixes that by applying the code for all `.notification_count`s. - Frontport will be in go-gitea#20543
- Since #20108 we have two version of the notification bell, one for mobile the other for non-mobile. However the code only accounts for one notification count and thus was only updating the non-mobile one. - This code fixes that by applying the code for all `.notification_count`s. - Frontport will be in #20543
* Adjust template for go-gitea#20069 smallbell * Adjust notification Unread Count variable to global and count bell position with mobile * Adjust bell icon style * Adjust smallbell to middle * Avoid using inline styles * move notificationUnreadCount to a general code block, reduce changed lines * Solved conflicts Co-authored-by: wxiaoguang <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: 6543 <[email protected]>
Unfortunately there is a bug in go-gitea#20108 where the translation call was not updated to use `.locale` from `.i18n`. This PR updates the template to use `.locale`. Signed-off-by: Andrew Thornton <[email protected]>
Closes #20069