Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust max-widths for the repository file table #20243

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Adjust max-widths for the repository file table #20243

merged 3 commits into from
Jul 5, 2022

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jul 5, 2022 •
edited
Loading

Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix #20040

Signed-off-by: Andrew Thornton [email protected]

Screenshots

MediaXL

Screenshot from 2022-07-05 10-22-12

MediaLg

Screenshot from 2022-07-05 10-24-37

MediaMd

Screenshot from 2022-07-05 10-23-03

MediaSm

Screenshot from 2022-07-05 10-26-44

@zeripath zeripath added topic/ui Change the appearance of the Gitea UI backport/v1.17 labels Jul 5, 2022
@zeripath zeripath added this to the 1.18.0 milestone Jul 5, 2022
@zeripath
Adjust max-widths for the repository file table
91b5ca0 
Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix go-gitea#20040

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath force-pushed the fix-20040-adjust-the-file-list-spacing branch from f82ae5c to 91b5ca0 Compare July 5, 2022 09:30
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 5, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 5, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #20243 (ee62044) into main (a168609) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #20243      +/-   ##
==========================================
- Coverage   46.96%   46.88%   -0.08%     
==========================================
  Files         973      973              
  Lines      134917   134917              
==========================================
- Hits        63363    63262     -101     
- Misses      63797    63884      +87     
- Partials     7757     7771      +14
Impacted Files Coverage Δ
modules/auth/openid/discovery_cache.go 8.00% <0.00%> (-92.00%) ⬇️
modules/templates/vars/vars.go 58.82% <0.00%> (-33.34%) ⬇️
modules/git/foreachref/parser.go 77.46% <0.00%> (-16.91%) ⬇️
modules/secret/secret.go 52.00% <0.00%> (-12.00%) ⬇️
modules/queue/queue_bytefifo.go 50.18% <0.00%> (-5.78%) ⬇️
services/pull/update.go 46.95% <0.00%> (-4.35%) ⬇️
modules/charset/charset.go 71.73% <0.00%> (-3.63%) ⬇️
modules/queue/queue_disk.go 60.00% <0.00%> (-3.34%) ⬇️
modules/paginator/paginator.go 97.16% <0.00%> (-2.84%) ⬇️
modules/notification/mail/mail.go 41.09% <0.00%> (-2.74%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a168609...ee62044. Read the comment docs.

@zeripath zeripath merged commit 8ee8230 into go-gitea:main Jul 5, 2022
@zeripath zeripath deleted the fix-20040-adjust-the-file-list-spacing branch July 5, 2022 11:33
zeripath added a commit to zeripath/gitea that referenced this pull request Jul 5, 2022
@zeripath
Adjust max-widths for the repository file table (go-gitea#20243)
65ad90c 
Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix go-gitea#20040

Signed-off-by: Andrew Thornton <[email protected]>

 ## Screenshots

 ## MediaXL
![Screenshot from 2022-07-05 10-22-12](https://user-images.githubusercontent.com/1824502/177295867-7ba8cf60-8f61-4227-892f-e5a0477e4146.png)

 ## MediaLg
![Screenshot from 2022-07-05 10-24-37](https://user-images.githubusercontent.com/1824502/177296301-e066e206-10f7-4a15-a68b-0f772a95f369.png)

 ## MediaMd
![Screenshot from 2022-07-05 10-23-03](https://user-images.githubusercontent.com/1824502/177295965-69397649-16ca-456a-bc0c-ed507fcb7f44.png)

 ## MediaSm
![Screenshot from 2022-07-05 10-26-44](https://user-images.githubusercontent.com/1824502/177296700-ca2a853b-c47b-4592-baf4-4bc08a7e1c9c.png)
@zeripath zeripath mentioned this pull request Jul 5, 2022
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Jul 5, 2022
zeripath added a commit that referenced this pull request Jul 5, 2022
@zeripath @lunny
Adjust max-widths for the repository file table (#20243) (#20247)
c88a59b 
Backport #20243

Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix #20040

Signed-off-by: Andrew Thornton <[email protected]>

 ## Screenshots

 ## MediaXL
![Screenshot from 2022-07-05 10-22-12](https://user-images.githubusercontent.com/1824502/177295867-7ba8cf60-8f61-4227-892f-e5a0477e4146.png)

 ## MediaLg
![Screenshot from 2022-07-05 10-24-37](https://user-images.githubusercontent.com/1824502/177296301-e066e206-10f7-4a15-a68b-0f772a95f369.png)

 ## MediaMd
![Screenshot from 2022-07-05 10-23-03](https://user-images.githubusercontent.com/1824502/177295965-69397649-16ca-456a-bc0c-ed507fcb7f44.png)

 ## MediaSm
![Screenshot from 2022-07-05 10-26-44](https://user-images.githubusercontent.com/1824502/177296700-ca2a853b-c47b-4592-baf4-4bc08a7e1c9c.png)

Co-authored-by: Lunny Xiao <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 7, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
310604f 
* upstream/main:
  Modify milestone search keywords to be case insensitive (go-gitea#20266)
  Fix toolip on mobile notification bell (go-gitea#20270)
  Allow RSA 2047 bit keys (go-gitea#20272)
  Refix notification bell placement (go-gitea#20251)
  Bump mermaid from 9.1.1 to 9.1.2 (go-gitea#20256)
  EscapeFilter the group dn membership (go-gitea#20200)
  Only show Followers that current user can access (go-gitea#20220)
  Init popup for new code comment (go-gitea#20234)
  Bypass Firefox (iOS) bug (go-gitea#20244)
  Adjust max-widths for the repository file table (go-gitea#20243)
  Display full name (go-gitea#20171)
  Adjust class for mobile has the problem of double small bells (go-gitea#20236)
  Adjust template for go-gitea#20069 smallbell (go-gitea#20108)
  Add integration tests for the Gitea migration form (go-gitea#20121)
  Allow dev i18n to be more concurrent (go-gitea#20159)
  Allow enable LDAP source and disable user sync via CLI (go-gitea#20206)
dineshsalunke pushed a commit to dineshsalunke/gitea that referenced this pull request Jul 9, 2022
@zeripath @dineshsalunke
Adjust max-widths for the repository file table (go-gitea#20243)
be710da 
Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix go-gitea#20040

Signed-off-by: Andrew Thornton <[email protected]>

## Screenshots

## MediaXL
![Screenshot from 2022-07-05 10-22-12](https://user-images.githubusercontent.com/1824502/177295867-7ba8cf60-8f61-4227-892f-e5a0477e4146.png)

## MediaLg
![Screenshot from 2022-07-05 10-24-37](https://user-images.githubusercontent.com/1824502/177296301-e066e206-10f7-4a15-a68b-0f772a95f369.png)

## MediaMd
![Screenshot from 2022-07-05 10-23-03](https://user-images.githubusercontent.com/1824502/177295965-69397649-16ca-456a-bc0c-ed507fcb7f44.png)

## MediaSm
![Screenshot from 2022-07-05 10-26-44](https://user-images.githubusercontent.com/1824502/177296700-ca2a853b-c47b-4592-baf4-4bc08a7e1c9c.png)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@zeripath
Adjust max-widths for the repository file table (go-gitea#20243)
75a3ade 
Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix go-gitea#20040

Signed-off-by: Andrew Thornton <[email protected]>

## Screenshots

## MediaXL
![Screenshot from 2022-07-05 10-22-12](https://user-images.githubusercontent.com/1824502/177295867-7ba8cf60-8f61-4227-892f-e5a0477e4146.png)

## MediaLg
![Screenshot from 2022-07-05 10-24-37](https://user-images.githubusercontent.com/1824502/177296301-e066e206-10f7-4a15-a68b-0f772a95f369.png)

## MediaMd
![Screenshot from 2022-07-05 10-23-03](https://user-images.githubusercontent.com/1824502/177295965-69397649-16ca-456a-bc0c-ed507fcb7f44.png)

## MediaSm
![Screenshot from 2022-07-05 10-26-44](https://user-images.githubusercontent.com/1824502/177296700-ca2a853b-c47b-4592-baf4-4bc08a7e1c9c.png)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

File names get truncated too aggressively on mobile version
5 participants
@zeripath @codecov-commenter @lunny @wxiaoguang @GiteaBot