Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golangci-lint warnings (#17598 et al) #17668

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 16, 2021

Backport #17598
Backport #17606
Backport #17608
Backport #17609

- Since https://gitea.com/gitea/test-env/pulls/10 the golangci-lint has
been upgraded and is erroring about new warnings in the code, this PR
fixes those warnings.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 16, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2021
@zeripath zeripath added this to the 1.15.7 milestone Nov 16, 2021
@zeripath
Copy link
Contributor

What PR is this a backport of?

@zeripath zeripath added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile and removed backport/v1.15 labels Nov 16, 2021
@Gusted
Copy link
Contributor Author

Gusted commented Nov 16, 2021

What PR is this a backport of?

#17598 #17606 #17608 and some other warnings that came along(which aren't present in the current master branch)

@zeripath zeripath changed the title backport: fix golangci-lint warnings Fix golangci-lint warnings (#17609) Nov 16, 2021
@zeripath zeripath changed the title Fix golangci-lint warnings (#17609) Fix golangci-lint warnings (#17598 et al) Nov 16, 2021
@zeripath zeripath merged commit ea0fe83 into go-gitea:release/v1.15 Nov 16, 2021
@Gusted Gusted deleted the backport-fix-lint branch November 16, 2021 20:40
@zeripath zeripath added topic/code-linting and removed topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Nov 16, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants