Remove golint as linter
#17609
Merged
Remove golint as linter
#17609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Partialy resolvess go-gitea#17596 - In the newer versions of `golangci-lint`, golint is deprecated and replaced by the `revive` linter. Thus removing the `golint` linter is a good idea, as we're already using the `revive` linter which covers all the current `golint` cases.
8 tasks
techknowlogick
approved these changes
Nov 10, 2021
GiteaBot
added
the
lgtm/need 1
silverwind
approved these changes
Nov 10, 2021
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #17609 +/- ##
=======================================
Coverage ? 45.50%
=======================================
Files ? 794
Lines ? 88861
Branches ? 0
=======================================
Hits ? 40439
Misses ? 41904
Partials ? 6518 Continue to review full report at Codecov.
|
|
I think this PR can be done by together. |
|
make L-G-T-M work. |
zeripath
pushed a commit
that referenced
this pull request
Nov 16, 2021
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
- Partialy resolvess go-gitea#17596 - In the newer versions of `golangci-lint`, golint is deprecated and replaced by the `revive` linter. Thus removing the `golint` linter is a good idea, as we're already using the `revive` linter which covers all the current `golint` cases. Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint, golint is deprecated and replaced by therevivelinter. Thus removing thegolintlinter is a good idea, as we're already using therevivelinter which covers all the currentgolintcases.