Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to allow comment poster to edit or delete his own comments #11671

Merged
merged 11 commits into from
Jun 5, 2020
Merged

Fix to allow comment poster to edit or delete his own comments #11671

merged 11 commits into from
Jun 5, 2020

Commits on May 29, 2020

  1. bug: fix comment update permision check 

    No the ui only allow poster to update or delet comment, which
is not reasonable and different with handle logic, this pr
change it to allow poster of comment do it

ref code:
https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1636

https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1681

fix go-gitea#11663

Signed-off-by: a1012112796 <[email protected]>
    @a1012112796
    a1012112796 committed May 29, 2020
    Configuration menu
    Copy the full SHA
    c91304f View commit details
    Browse the repository at this point in the history

  2. simplify code

    @a1012112796
    a1012112796 committed May 29, 2020
    Configuration menu
    Copy the full SHA
    72a23da View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix_comment_update_perm

    @a1012112796
    a1012112796 committed May 29, 2020
    Configuration menu
    Copy the full SHA
    e9351f8 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2020

  1. fix sign in

    @a1012112796
    a1012112796 committed May 30, 2020
    Configuration menu
    Copy the full SHA
    102abf9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix_comment_update_perm

    @a1012112796
    a1012112796 committed May 30, 2020
    Configuration menu
    Copy the full SHA
    97903a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Merge branch 'master' into fix_comment_update_perm

    @a1012112796
    a1012112796 authored Jun 1, 2020
    Configuration menu
    Copy the full SHA
    a5e324d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix_comment_update_perm

    @a1012112796
    a1012112796 authored Jun 1, 2020
    Configuration menu
    Copy the full SHA
    8f02f6e View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Merge branch 'master' into fix_comment_update_perm

    @a1012112796
    a1012112796 authored Jun 4, 2020
    Configuration menu
    Copy the full SHA
    3579867 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix_comment_update_perm

    @zeripath
    zeripath authored Jun 4, 2020
    Configuration menu
    Copy the full SHA
    c35e4cf View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix_comment_update_perm

    @lafriks
    lafriks authored Jun 4, 2020
    Configuration menu
    Copy the full SHA
    0f3d9d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. Merge branch 'master' into fix_comment_update_perm

    @lafriks
    lafriks authored Jun 5, 2020
    Configuration menu
    Copy the full SHA
    0090d28 View commit details
    Browse the repository at this point in the history