Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to edit their own comments, without needing full Write permission #11663

Closed
2 of 7 tasks
mappu opened this issue May 28, 2020 · 0 comments · Fixed by #11671
Closed
2 of 7 tasks

Allow users to edit their own comments, without needing full Write permission #11663

mappu opened this issue May 28, 2020 · 0 comments · Fixed by #11671

Comments

@mappu
Copy link
Contributor

mappu commented May 28, 2020

  • Gitea version (or commit ref): 1.11.3
  • Git version: 2.24.1
  • Operating system: Linux (Docker)
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

I have some people with access to a repository, that can report issues, but only a developer can resolve the issues.

These people are unable to edit/delete their own comments (to fix typos, or add more information, or delete comment that was added into the wrong issue)

I would like for them to be able to edit/delete their own comments, without, needing to give them the full Write access.

Maybe it's similar to this other request https://discourse.gitea.io/t/how-to-allow-collaborators-to-edit-their-own-comments-in-1-5-x/581
a1012112796 added a commit to a1012112796/gitea that referenced this issue May 29, 2020
@a1012112796
bug: fix comment update permision check
c91304f 
No the ui only allow poster to update or delet comment, which
is not reasonable and different with handle logic, this pr
change it to allow poster of comment do it

ref code:
https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1636

https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1681

fix go-gitea#11663

Signed-off-by: a1012112796 <[email protected]>
@a1012112796 a1012112796 mentioned this issue May 29, 2020
Merged
lafriks added a commit that referenced this issue Jun 5, 2020
@a1012112796 @zeripath @lafriks
Fix to allow comment poster to edit or delete his own comments (#11671)
17f8de7 
* bug: fix comment update permision check

No the ui only allow poster to update or delet comment, which
is not reasonable and different with handle logic, this pr
change it to allow poster of comment do it

ref code:
https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1636

https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1681

fix #11663

Signed-off-by: a1012112796 <[email protected]>

* simplify code

* fix sign in

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
a1012112796 added a commit to a1012112796/gitea that referenced this issue Jun 5, 2020
@a1012112796 @zeripath @lafriks
Fix to allow comment poster to edit or delete his own comments (go-gi…
ccf3a91 
…tea#11671)

* bug: fix comment update permision check

No the ui only allow poster to update or delet comment, which
is not reasonable and different with handle logic, this pr
change it to allow poster of comment do it

ref code:
https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1636

https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1681

fix go-gitea#11663

Signed-off-by: a1012112796 <[email protected]>

* simplify code

* fix sign in

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
techknowlogick pushed a commit that referenced this issue Jun 6, 2020
@a1012112796 @zeripath @lafriks
Fix to allow comment poster to edit or delete his own comments (#11671)…
821570c 
… (#11774)

* bug: fix comment update permision check

No the ui only allow poster to update or delet comment, which
is not reasonable and different with handle logic, this pr
change it to allow poster of comment do it

ref code:
https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1636

https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1681

fix #11663

Signed-off-by: a1012112796 <[email protected]>

* simplify code

* fix sign in

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lauris BH <[email protected]>

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@a1012112796 @zeripath @lafriks
Fix to allow comment poster to edit or delete his own comments (go-gi…
dd5983f 
…tea#11671)

* bug: fix comment update permision check

No the ui only allow poster to update or delet comment, which
is not reasonable and different with handle logic, this pr
change it to allow poster of comment do it

ref code:
https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1636

https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1681

fix go-gitea#11663

Signed-off-by: a1012112796 <[email protected]>

* simplify code

* fix sign in

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix to allow comment poster to edit or delete his own comments a1012112796/gitea
1 participant
@mappu