Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix orgs not being displayed on create repo form #11279

Merged
merged 2 commits into from
May 3, 2020
Merged

Fix orgs not being displayed on create repo form #11279

merged 2 commits into from
May 3, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 2, 2020 •
edited by zeripath
Loading

#11183 prevents the Create Repository dialog from displaying orgs that the user has the createRepository permission on.

Steps to reproduce:

  • User 1 creates an organization A
  • When User 1 attempts to create a new repository, A should be allowed to be chosen as the owner

The problem is that the function MUST put the Orgs list in to the context before second conditional

@lunny lunny added the type/enhancement An improvement of existing functionality label May 2, 2020
zeripath
zeripath approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the bug for the moment but all of this code needs rationalising

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2020
@guillep2k
Copy link
Member

Fixes #11258

@guillep2k guillep2k linked an issue May 3, 2020 that may be closed by this pull request
organization listed multiple times when creating a repository #11258
Closed
2 tasks
@guillep2k guillep2k merged commit b7c82cd into go-gitea:master May 3, 2020
@lafriks lafriks added this to the 1.12.0 milestone May 4, 2020
@lunny
Copy link
Member

lunny commented May 4, 2020

Please send back port to v1.11

@CirnoT
Copy link
Contributor Author

CirnoT commented May 4, 2020

Are you sure @lunny? #11183 was not backported and this PR depends on it and simply fixes what it has broken.

@guillep2k I am unsure if this PR or #11183 fixes the mentioned issue as it refers to v1.11, so before original PR landed and broke things.

@CirnoT
Copy link
Contributor Author

CirnoT commented May 4, 2020 •
edited
Loading

Can confirm now that neither of these PR fixes the mentioned issue @guillep2k

Most likely this PR should be skip-changelog now as it fixes the issue introduced by another PR before release was made.

@zeripath zeripath added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed backport/v1.11 labels May 4, 2020
@guillep2k
Copy link
Member

Thank you @CirnoT, I got confused about the issue. 👍

@CirnoT CirnoT deleted the repo-context branch May 11, 2020 20:02
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT
Fix orgs not being displayed on create repo form (go-gitea#11279)
022342e
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

organization listed multiple times when creating a repository
7 participants
@CirnoT @guillep2k @lunny @mrsdizzie @zeripath @lafriks @GiteaBot