Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing commit states to PR checks template #11085

Merged
merged 6 commits into from
Apr 16, 2020
Merged

Add missing commit states to PR checks template #11085

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a3d076
Add missing commit states to PR checks template
CirnoT Apr 15, 2020
28b6528
Add separate translation strings for warning and error
CirnoT Apr 16, 2020
79f84b2
Fix failure status string
CirnoT Apr 16, 2020
814a277
Revert accidental change with whitespace
CirnoT Apr 16, 2020
cae653d
Merge branch 'master' into patch-3
jolheiser Apr 16, 2020
a3ba01a
Merge branch 'master' into patch-3
jolheiser Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix failure status string
  • Loading branch information
@CirnoT
CirnoT committed Apr 16, 2020
commit 79f84b279035895008ca1d3b01f021c272aa0b49
4 changes: 2 additions & 2 deletions templates/repo/pulls/status.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{{else if eq .LatestCommitStatus.State "warning"}}
{{$.i18n.Tr "repo.pulls.status_checks_warning"}}
{{else if eq .LatestCommitStatus.State "failure"}}
{{$.i18n.Tr "repo.pulls.status_checks_error"}}
{{$.i18n.Tr "repo.pulls.status_checks_failure"}}
{{else if eq .LatestCommitStatus.State "error"}}
{{$.i18n.Tr "repo.pulls.status_checks_error"}}
{{else}}
Expand All @@ -21,7 +21,7 @@
<span class="ui">{{.Context}} <span class="text grey">{{.Description}}</span></span>
<div class="ui right">
{{if $.is_context_required}}
{{if (call $.is_context_required .Context)}}<div class="ui label">Required</div>{{end}}
{{if (call $.is_context_required .Context)}}<div class="ui label">Required</div>{{end}}
{{end}}
<span class="ui">{{if .TargetURL}}<a href="{{.TargetURL}}">Details</a>{{end}}</span>
</div>
Expand Down