Add missing commit states to PR checks template #11085
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template was missing case for
failure
state, causing 'Some checks are pending' to be displayed incorrectly.There was also a missing case for
warning
- I have decided to use translation forsuccess
in such case, but we might want to add new translation for it.On an unrelated note, and possibly for another PR; we might want to distinguish between
error
andfailure
state in translations, just like GitHub does (errored vs failed) as they can mean very different things (for example CI failed to execute pipeline due to some internal error vs pipeline failed)