Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent support libraries from compiling into Gitea #10964

Merged
merged 4 commits into from
Apr 5, 2020

Conversation

guillep2k
Copy link
Member

This PR should prevent support vendored libraries from being compiled into Gitea, thus keeping the file size to what is needed.

@lunny #10942 (comment)

@guillep2k guillep2k added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 4, 2020
@guillep2k guillep2k added this to the 1.12.0 milestone Apr 4, 2020
@guillep2k guillep2k added the pr/wip This PR is not ready for review label Apr 4, 2020
@guillep2k guillep2k removed the pr/wip This PR is not ready for review label Apr 4, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 5, 2020
@guillep2k
Copy link
Member Author

I'm not sure there's something wrong with Codecov. It didn't add a comment. Maybe it's a Codecove glitch, because I can't find any errors in the build.

I'm still investigating the issue, but I'm unable to generate the coverage report in my setting, I'm not sure why.

@codecov-io
Copy link

codecov-io commented Apr 5, 2020

Codecov Report

Merging #10964 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10964      +/-   ##
==========================================
+ Coverage   43.61%   43.64%   +0.02%     
==========================================
  Files         597      597              
  Lines       83923    83923              
==========================================
+ Hits        36602    36624      +22     
+ Misses      42809    42791      -18     
+ Partials     4512     4508       -4     
Impacted Files Coverage Δ
models/gpg_key.go 53.42% <0.00%> (-0.53%) ⬇️
modules/git/repo.go 48.11% <0.00%> (+0.83%) ⬆️
services/pull/check.go 55.48% <0.00%> (+2.43%) ⬆️
services/pull/temp_repo.go 31.62% <0.00%> (+2.56%) ⬆️
services/pull/patch.go 65.73% <0.00%> (+2.79%) ⬆️
modules/git/utils.go 70.14% <0.00%> (+4.47%) ⬆️
modules/indexer/stats/db.go 59.37% <0.00%> (+18.75%) ⬆️
modules/indexer/stats/queue.go 81.25% <0.00%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf71ee...8425556. Read the comment docs.

@guillep2k
Copy link
Member Author

OK, it was only a Codecov glitch. 😅

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2020
@lunny
Copy link
Member

lunny commented Apr 5, 2020

make L-G-T-M work

@lunny lunny merged commit b74d30a into go-gitea:master Apr 5, 2020
@guillep2k guillep2k deleted the isolate-vendor branch April 5, 2020 03:37
@jolheiser jolheiser mentioned this pull request Apr 5, 2020
@jolheiser
Copy link
Member

My apologies for not looking at this earlier, it feels like it's been a wild day. 🐔 🔪 😵

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants