Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitea-vet #10948

Merged
merged 6 commits into from
Apr 5, 2020
Merged

Add gitea-vet #10948

merged 6 commits into from
Apr 5, 2020

Conversation

jolheiser
Copy link
Member

@lunny I'm not sure whether this can be incorporated into the build folder because of how go vet wants it to work, let me know if I need to change something.

This PR adds gitea-vet as a custom vet tool.

Currently it only has two checks, more can be added later.

  1. Check for sort order. stdlib -> code.gitea.io -> other
  2. Check file headers for some form of Copyright...YYYY...Gitea/Gogs

@jolheiser jolheiser added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Apr 4, 2020
@jolheiser jolheiser added this to the 1.12.0 milestone Apr 4, 2020
Makefile Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 4, 2020
tools.go Outdated Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Apr 4, 2020

Pelase resolve the conflicts.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2020
@jolheiser
Copy link
Member Author

Don't merge this yet. I have a few things to clean up since #10964 was merged.

@jolheiser
Copy link
Member Author

Okay, so a few more things in here.

I combined tools.go into build.go since they effectively did the exact same thing.
As well, I removed the extra tag from our Makefile.

go mod tidy:

Prune any no-longer-needed dependencies from go.mod and 
add any dependencies needed for other combinations of OS, architecture, and build tags

So we will still vendor them without explicitly giving a build tag.

Makefile Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #10948 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10948      +/-   ##
==========================================
- Coverage   43.62%   43.61%   -0.02%     
==========================================
  Files         597      597              
  Lines       83923    83923              
==========================================
- Hits        36613    36599      -14     
- Misses      42799    42811      +12     
- Partials     4511     4513       +2     
Impacted Files Coverage Δ
models/lfs.go 17.27% <ø> (ø)
modules/lfs/content_store.go 45.33% <ø> (ø)
modules/lfs/server.go 40.35% <ø> (ø)
routers/api/v1/misc/signing.go 0.00% <ø> (ø)
routers/repo/middlewares.go 59.09% <ø> (ø)
routers/swagger_json.go 0.00% <ø> (ø)
services/pull/check.go 48.17% <0.00%> (-3.66%) ⬇️
modules/process/manager.go 74.69% <0.00%> (-3.62%) ⬇️
services/pull/patch.go 62.93% <0.00%> (-2.80%) ⬇️
services/pull/temp_repo.go 29.05% <0.00%> (-2.57%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74d30a...20d7da1. Read the comment docs.

@zeripath zeripath merged commit baadb51 into go-gitea:master Apr 5, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants